From bd9446b5be9cd5aefa715c1cc1faf3188238b88c Mon Sep 17 00:00:00 2001 From: UENISHI Kota Date: Thu, 13 Nov 2025 12:58:57 +0900 Subject: [PATCH 1/2] Print message only when verbose is on --- pfio/v2/s3.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pfio/v2/s3.py b/pfio/v2/s3.py index 561975f..4e6e582 100644 --- a/pfio/v2/s3.py +++ b/pfio/v2/s3.py @@ -428,7 +428,8 @@ def __init__(self, bucket, prefix=None, else: # self.endpoint is not defined in moto3 environment self.hostname = "undefined" - print("S3 endpoint is not defined") + if self.verbose: + print("S3 endpoint is not defined") def _reset(self): self._connect() @@ -447,7 +448,8 @@ def _connect(self): except ClientError as e: if e.response['Error']['Code'] == '404' and self.create_bucket: res = self.client.create_bucket(Bucket=self.bucket) - print("Bucket", self.bucket, "created:", res) + if self.verbose: + print("Bucket", self.bucket, "created:", res) else: raise e From 0dc6a33d894493bdd7ca558964980c988ee7706e Mon Sep 17 00:00:00 2001 From: UENISHI Kota Date: Tue, 19 May 2026 10:12:45 +0900 Subject: [PATCH 2/2] Use stderr instead of verbose --- pfio/v2/s3.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/pfio/v2/s3.py b/pfio/v2/s3.py index 4e6e582..346b2f2 100644 --- a/pfio/v2/s3.py +++ b/pfio/v2/s3.py @@ -2,6 +2,7 @@ import hashlib import io import os +import sys import urllib.parse from types import TracebackType from typing import Optional, Type @@ -428,14 +429,12 @@ def __init__(self, bucket, prefix=None, else: # self.endpoint is not defined in moto3 environment self.hostname = "undefined" - if self.verbose: - print("S3 endpoint is not defined") + print("S3 endpoint is not defined", file=sys.stderr) def _reset(self): self._connect() def _connect(self): - # print('boto3.client options:', kwargs) config = Config(**self.botocore_config) obj = boto3.client('s3', config=config, **self.kwargs) if self.trace: @@ -448,8 +447,7 @@ def _connect(self): except ClientError as e: if e.response['Error']['Code'] == '404' and self.create_bucket: res = self.client.create_bucket(Bucket=self.bucket) - if self.verbose: - print("Bucket", self.bucket, "created:", res) + print("Bucket", self.bucket, "created:", res, file=sys.stderr) else: raise e