small cleanup

Author: Boy132

player-counter/src/Extensions/Query/Schemas/MinecraftJavaQueryTypeSchema.php

@@ -27,28 +27,9 @@ public function process(string $ip, int $port): ?array
             return $query;
         }
 
-        try {
-            $ping = new MinecraftPing($ip, $port, 5, true);
-
-            $data = $ping->Query();
-
-            if (!$data) {
-                return null;
-            }
-
-            return [
-                'hostname' => is_string($data['description']) ? $data['description'] : $data['description']['text'],
-                'map' => 'world', // No map from MinecraftPing
-                'current_players' => $data['players']['online'],
-                'max_players' => $data['players']['max'],
-                'players' => $data['players']['sample'] ?? [],
-            ];
-        } catch (Exception $exception) {
-            report($exception);
-        } finally {
-            if (isset($ping)) {
-                $ping->Close();
-            }
+        $ping = $this->tryPing($ip, $port);
+        if ($ping) {
+            return $ping;
         }
 
         return null;
@@ -82,4 +63,34 @@ protected function tryQuery(string $ip, int $port): false|array
 
         return false;
     }
+
+    /** @return false|array{hostname: string, map: string, current_players: int, max_players: int, players: array<array{id: string, name: string}>} */
+    protected function tryPing(string $ip, int $port): false|array
+    {
+        try {
+            $ping = new MinecraftPing($ip, $port, 5, true);
+
+            $data = $ping->Query();
+
+            if (!$data) {
+                return false;
+            }
+
+            return [
+                'hostname' => is_string($data['description']) ? $data['description'] : $data['description']['text'],
+                'map' => 'world', // No map from MinecraftPing
+                'current_players' => $data['players']['online'],
+                'max_players' => $data['players']['max'],
+                'players' => $data['players']['sample'] ?? [],
+            ];
+        } catch (Exception $exception) {
+            report($exception);
+        } finally {
+            if (isset($ping)) {
+                $ping->Close();
+            }
+        }
+
+        return false;
+    }
 }