[improve] Replace ajax "done" function with success & error arguments

Author: luciandex

upload_ce_phoenix/includes/javascript/paylike.js

@@ -24,20 +24,25 @@ function pay(args, checkout, form) {
       data: {
         action: 'setTransactionId',
         id: r.transaction.id
-      }
-    }).done(function(r) {
-      if (r.err) {
-        return 0;
-      }
-      if (checkout) {
-        checkout.checkAllErrors();
-      } else {
-        /* Remove form submit event which prevent form action to proceed */
-        /* Set form action attribute */
-        /* Force submit form */
-        $(form).off('submit', submitForm).attr("action", $(form).find("#payLikeCheckout").attr("action")).submit();
+      },
+      error: function(jqXHR, textStatus, errorThrown) {
+        if (errorThrown) {
+          console.error(errorThrown);
+          return 0;
+        }
+      },
+      success: function(data, textStatus, jqXH) {
+        if (checkout) {
+          checkout.checkAllErrors();
+        } else {
+          /* Remove form submit event which prevent form action to proceed */
+          /* Set form action attribute */
+          /* Force submit form */
+          $(form).off('submit', submitForm).attr("action", $(form).find("#payLikeCheckout").attr("action")).submit();
+        }
       }
     })
+
     return false;
   });
 }
@@ -57,12 +62,14 @@ function submitForm(e) {
     url: orderDataPath,
     data: {
       action: 'getOrderTotalsData'
+    },
+    error: function(jqXHR, textStatus, errorThrown) {
+      console.error(errorThrown);
+    },
+    success: function(data, textStatus, jqXHR) {
+      var checkoutObj = (typeof checkout === 'undefined') ? (false) : (checkout);
+      pay(data, checkoutObj, form);
     }
-  }).done(function(r) {
-    var checkoutObj = typeof checkout === 'undefined'
-      ? false
-      : checkout;
-    pay(r, checkoutObj, form);
   })
   /* Prevent form action to proceed */
   e.preventDefault(e);