Skip to content

Commit d0b0217

Browse files
committed
Remove duplicate maven plugin and add better maven config for jar sign
1 parent 97c0699 commit d0b0217

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ set as `pfopensource`.
360360
If you want to skip jar signing just change the skip configuration in the
361361
`pom.xml` jar sign plugin to true:
362362

363-
<skip>true</skip>
363+
<project.skipJarSign>true</project.skipJarSign>
364364

365365
### Build with Maven
366366

pom.xml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
<properties>
2424
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
2525
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
26+
<project.skipJarSign>false
27+
</project.skipJarSign> <!-- set this to true if fail because of missing credentials -->
2628
</properties>
2729

2830
<repositories>
@@ -96,11 +98,6 @@
9698
</dependency>
9799
</dependencies>
98100
</plugin>
99-
<plugin>
100-
<groupId>org.apache.maven.plugins</groupId>
101-
<artifactId>maven-surefire-plugin</artifactId>
102-
<version>2.22.0</version>
103-
</plugin>
104101
<plugin>
105102
<groupId>org.jacoco</groupId>
106103
<artifactId>jacoco-maven-plugin</artifactId>
@@ -132,7 +129,7 @@
132129
</execution>
133130
</executions>
134131
<configuration>
135-
<skip>false</skip> <!-- set this to true if fail because of missing credentials -->
132+
<skip>${project.skipJarSign}</skip>
136133
<keystore>${session.executionRootDirectory}/keystore.jks</keystore>
137134
<alias>pfopensource</alias>
138135
<storepass>${env.OPENSOURCE_PROJECTS_KS_PW}</storepass>

0 commit comments

Comments
 (0)