Skip to content

hiffy/net feature seems to break using hiffy via a probe on Cosmo #2528

@hawkw

Description

@hawkw

Today I spent a longish amount of time debugging a situation in which I could not use humility commands that rely on hiffy on the Cosmo mb-1. After messing with a bunch of stuff related to atomic ordering which turned out to NOT MATTER AT ALL, @jamesmunns, @mkeeter, and I determined that actually, it was #2466 that broke it, and if one just removed the net feature flag from hiffy, it works.

With an image built from a recent commit of #2519:

eliza@jeeves ~ $ pfexec humility -t mb-1-sp net ip
humility: WARNING: archive in environment variable overriding archive in environment file
humility: attached to 1fc9:0143:ISS1EG0OBG2HT via CMSIS-DAP
humility net failed: operation timed out
eliza@jeeves ~ $ pfexec humility -t mb-1-sp net ip
humility: WARNING: archive in environment variable overriding archive in environment file
humility: attached to 1fc9:0143:ISS1EG0OBG2HT via CMSIS-DAP
humility net failed: operation timed out
eliza@jeeves ~ $ pfexec humility -t mb-1-sp net ip
humility: WARNING: archive in environment variable overriding archive in environment file
humility: attached to 1fc9:0143:ISS1EG0OBG2HT via CMSIS-DAP
humility net failed: operation timed out
eliza@jeeves ~ $

Which is not supposed to happen!

After applying this patch:

diff --git a/app/cosmo/dev.toml b/app/cosmo/dev.toml
index 3c23b437..9acde926 100644
--- a/app/cosmo/dev.toml
+++ b/app/cosmo/dev.toml
@@ -29,9 +29,9 @@ port = 998
 tx = { packets = 3, bytes = 1024 }
 rx = { packets = 3, bytes = 1024 }

-[tasks.hiffy]
-features = ["net", "vlan"]
-notifications = ["socket"]
+# [tasks.hiffy]
+# features = ["net", "vlan"]
+# notifications = ["socket"]

 [config.net.sockets.fmc_test]
 kind = "udp"
@@ -40,9 +40,9 @@ port = 11114
 tx = { packets = 3, bytes = 4096 }
 rx = { packets = 3, bytes = 4096 }

-[config.net.sockets.hiffy]
-kind = "udp"
-owner = {name = "hiffy", notification = "socket"}
-port = 11115
-tx = { packets = 3, bytes = 32 }
-rx = { packets = 1, bytes = 4096 }
+# [config.net.sockets.hiffy]
+# kind = "udp"
+# owner = {name = "hiffy", notification = "socket"}
+# port = 11115
+# tx = { packets = 3, bytes = 32 }
+# rx = { packets = 1, bytes = 4096 }

it once again works:

eliza@jeeves ~ $ export HUMILITY_ARCHIVE=build-cosmo-b-dev-image-default.netless.zip
eliza@jeeves ~ $ pfexec /staff/eliza/humility -t mb-1-sp flash
humility: WARNING: archive in environment variable overriding archive in environment file
humility: attached to archive
humility: attaching with chip set to "STM32H753ZITx"
humility: attached to 1fc9:0143:ISS1EG0OBG2HT via CMSIS-DAP
humility: flash/archive mismatch; reflashing
humility: skipping measurement token handoff
humility: auxiliary flash data is already loaded in slot 0; skipping programming
humility: done with auxiliary flash
humility: flashing done
eliza@jeeves ~ $ pfexec /staff/eliza/humility -t mb-1-sp net ip
humility: WARNING: archive in environment variable overriding archive in environment file
humility: attached to 1fc9:0143:ISS1EG0OBG2HT via CMSIS-DAP
MAC address:  a8:40:25:04:11:c5
IPv6 address: fe80::aa40:25ff:fe04:11c5
eliza@jeeves ~ $

Metadata

Metadata

Assignees

No one assigned

    Labels

    affects-humilityWill have debug interface impact and may require corresponding changes in the debuggercosmoSP5 Board

    Type

    No fields configured for Bug.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions