refactor: check password-enforced capability in the ViewModel instead of the Fragment

Author: joragua

owncloudApp/src/main/java/com/owncloud/android/presentation/capabilities/CapabilityViewModel.kt

@@ -25,10 +25,12 @@ package com.owncloud.android.presentation.capabilities
 import androidx.lifecycle.LiveData
 import androidx.lifecycle.MediatorLiveData
 import androidx.lifecycle.ViewModel
+import com.owncloud.android.domain.capabilities.model.CapabilityBooleanType
 import com.owncloud.android.domain.capabilities.model.OCCapability
 import com.owncloud.android.domain.capabilities.usecases.GetCapabilitiesAsLiveDataUseCase
 import com.owncloud.android.domain.capabilities.usecases.GetStoredCapabilitiesUseCase
 import com.owncloud.android.domain.capabilities.usecases.RefreshCapabilitiesFromServerAsyncUseCase
+import com.owncloud.android.domain.links.model.OCLinkType
 import com.owncloud.android.domain.utils.Event
 import com.owncloud.android.extensions.ViewModelExt.runUseCaseWithResultAndUseCachedData
 import com.owncloud.android.presentation.common.UIResult
@@ -80,4 +82,12 @@ class CapabilityViewModel(
         }
         capabilities?.spaces?.hasMultiplePersonalSpaces == true
     }
+
+    fun checkPasswordEnforced(selectedPermission: OCLinkType, capabilities: OCCapability?) =
+        when(selectedPermission) {
+            OCLinkType.CAN_VIEW -> capabilities?.filesSharingPublicPasswordEnforcedReadOnly == CapabilityBooleanType.TRUE
+            OCLinkType.CAN_EDIT -> capabilities?.filesSharingPublicPasswordEnforcedReadWrite == CapabilityBooleanType.TRUE
+            OCLinkType.CREATE_ONLY -> capabilities?.filesSharingPublicPasswordEnforcedUploadOnly == CapabilityBooleanType.TRUE
+            else -> true
+        }
 }

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/links/AddPublicLinkFragment.kt

@@ -31,7 +31,6 @@ import androidx.core.view.isVisible
 import androidx.fragment.app.Fragment
 import com.owncloud.android.R
 import com.owncloud.android.databinding.AddPublicLinkFragmentBinding
-import com.owncloud.android.domain.capabilities.model.CapabilityBooleanType
 import com.owncloud.android.domain.capabilities.model.OCCapability
 import com.owncloud.android.domain.links.model.OCLinkType
 import com.owncloud.android.domain.spaces.model.OCSpace
@@ -198,27 +197,10 @@ class AddPublicLinkFragment: Fragment(), SetPasswordDialogFragment.SetPasswordLi
             selectedRadioButton.isChecked = true
         }
         val selectedPermission = selectedRadioButton.tag as OCLinkType
-        checkPasswordEnforced(selectedPermission)
+        isPasswordEnforced = capabilityViewModel.checkPasswordEnforced(selectedPermission, capabilities)
         spaceLinksViewModel.onPermissionSelected(selectedPermission)
     }
 
-    private fun checkPasswordEnforced(selectedPermission: OCLinkType) {
-        isPasswordEnforced = when (selectedPermission) {
-            OCLinkType.CAN_VIEW -> {
-                capabilities?.filesSharingPublicPasswordEnforcedReadOnly == CapabilityBooleanType.TRUE
-            }
-            OCLinkType.CAN_EDIT -> {
-                capabilities?.filesSharingPublicPasswordEnforcedReadWrite == CapabilityBooleanType.TRUE
-            }
-            OCLinkType.CREATE_ONLY -> {
-                capabilities?.filesSharingPublicPasswordEnforcedUploadOnly == CapabilityBooleanType.TRUE
-            }
-            else -> {
-                true
-            }
-        }
-    }
-
     private fun bindDatePickerDialog(expirationDate: String?) {
         binding.expirationDateLayout.expirationDateSwitch.setOnCheckedChangeListener { _, isChecked ->
             if (isChecked) {