Skip to content

Commit cabddc9

Browse files
authored
Merge pull request #3654 from owncloud/bugfix/lock_back
[BUGFIX] Pattern/Passcode is asked when browsing back
2 parents f4fa442 + dfd9af4 commit cabddc9

3 files changed

Lines changed: 12 additions & 10 deletions

File tree

owncloudApp/src/main/java/com/owncloud/android/MainApp.kt

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ import com.owncloud.android.dependecyinjection.useCaseModule
4545
import com.owncloud.android.dependecyinjection.viewModelModule
4646
import com.owncloud.android.extensions.createNotificationChannel
4747
import com.owncloud.android.lib.common.SingleSessionManager
48-
import com.owncloud.android.presentation.ui.authentication.LoginActivity
4948
import com.owncloud.android.presentation.ui.migration.StorageMigrationActivity
5049
import com.owncloud.android.presentation.ui.releasenotes.ReleaseNotesActivity
5150
import com.owncloud.android.presentation.ui.security.BiometricActivity
@@ -57,8 +56,6 @@ import com.owncloud.android.presentation.ui.security.passcode.PassCodeManager
5756
import com.owncloud.android.presentation.ui.settings.fragments.SettingsLogsFragment.Companion.PREFERENCE_ENABLE_LOGGING
5857
import com.owncloud.android.providers.LogsProvider
5958
import com.owncloud.android.providers.MdmProvider
60-
import com.owncloud.android.ui.activity.FileDisplayActivity
61-
import com.owncloud.android.ui.activity.SplashActivity
6259
import com.owncloud.android.ui.activity.WhatsNewActivity
6360
import com.owncloud.android.utils.CONFIGURATION_ALLOW_SCREENSHOTS
6461
import com.owncloud.android.utils.DOWNLOAD_NOTIFICATION_CHANNEL_ID
@@ -130,13 +127,8 @@ class MainApp : Application() {
130127

131128
override fun onActivityStarted(activity: Activity) {
132129
Timber.v("${activity.javaClass.simpleName} onStart() starting")
133-
if (activity is SplashActivity ||
134-
activity is FileDisplayActivity ||
135-
activity is LoginActivity
136-
) {
137-
PassCodeManager.onActivityStarted(activity)
138-
PatternManager.onActivityStarted(activity)
139-
}
130+
PassCodeManager.onActivityStarted(activity)
131+
PatternManager.onActivityStarted(activity)
140132
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
141133
BiometricManager.onActivityStarted(activity)
142134
}

owncloudApp/src/main/java/com/owncloud/android/presentation/ui/security/PatternActivity.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,11 @@ class PatternActivity : AppCompatActivity(), IEnableBiometrics {
147147
return true
148148
}
149149

150+
override fun onBackPressed() {
151+
PatternManager.onActivityStopped(this)
152+
super.onBackPressed()
153+
}
154+
150155
/**
151156
* Binds the appropriate listener to the pattern view.
152157
*/

owncloudApp/src/main/java/com/owncloud/android/presentation/ui/security/passcode/PassCodeActivity.kt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,11 @@ class PassCodeActivity : AppCompatActivity(), NumberKeyboardListener, IEnableBio
166166
return true
167167
}
168168

169+
override fun onBackPressed() {
170+
PassCodeManager.onActivityStopped(this)
171+
super.onBackPressed()
172+
}
173+
169174
private fun inflatePasscodeTxtLine() {
170175
val layout_code = findViewById<LinearLayout>(R.id.layout_code)
171176
val numberOfPasscodeDigits = (passCodeViewModel.getPassCode()?.length ?: passCodeViewModel.getNumberOfPassCodeDigits())

0 commit comments

Comments
 (0)