refactor: move create space link listener out of observer method

Author: joragua

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/links/AddPublicLinkFragment.kt

@@ -104,16 +104,7 @@ class AddPublicLinkFragment: Fragment(), SetPasswordDialogFragment.SetPasswordLi
                         setPasswordSwitch.isVisible = !isPasswordEnforced
                         setPasswordSwitch.isChecked = hasPassword
                     }
-                    binding.createPublicLinkButton.isEnabled = isPasswordEnforced && hasPassword || !isPasswordEnforced
-
-                    binding.createPublicLinkButton.setOnClickListener {
-                        spaceLinksViewModel.createPublicLink(
-                            binding.publicLinkNameEditText.text.toString().ifEmpty { getString(R.string.public_link_default_display_name) },
-                            selectedPermission,
-                            uiState.selectedExpirationDate,
-                            uiState.selectedPassword,
-                        )
-                    }
+                    binding.createPublicLinkButton.isEnabled = (isPasswordEnforced && hasPassword) || !isPasswordEnforced
                 }
 
                 bindDatePickerDialog(uiState.selectedExpirationDate)
@@ -181,6 +172,12 @@ class AddPublicLinkFragment: Fragment(), SetPasswordDialogFragment.SetPasswordLi
                 if (setPasswordSwitch.isChecked) showPasswordDialog() else removePassword()
             }
         }
+
+        binding.createPublicLinkButton.setOnClickListener {
+            spaceLinksViewModel.createPublicLink(
+                binding.publicLinkNameEditText.text.toString().ifEmpty { getString(R.string.public_link_default_display_name) }
+            )
+        }
     }
 
     override fun onCancelPassword() {

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/links/SpaceLinksViewModel.kt

@@ -61,20 +61,22 @@ class SpaceLinksViewModel(
         _addPublicLinkUIState.update { it?.copy(selectedPassword = password) }
     }
 
-    fun createPublicLink(displayName: String, permission: OCLinkType, expirationDate: String?, password: String?) {
-        runUseCaseWithResult(
-            coroutineDispatcher = coroutineDispatcherProvider.io,
-            flow = _addLinkResultFlow,
-            useCase = addLinkUseCase,
-            useCaseParams = AddLinkUseCase.Params(
-                accountName = accountName,
-                spaceId = space.id,
-                displayName = displayName,
-                type = permission,
-                expirationDate = expirationDate,
-                password = password
+    fun createPublicLink(displayName: String) {
+        _addPublicLinkUIState.value?.selectedPermission?.let {
+            runUseCaseWithResult(
+                coroutineDispatcher = coroutineDispatcherProvider.io,
+                flow = _addLinkResultFlow,
+                useCase = addLinkUseCase,
+                useCaseParams = AddLinkUseCase.Params(
+                    accountName = accountName,
+                    spaceId = space.id,
+                    displayName = displayName,
+                    type = it,
+                    expirationDate = _addPublicLinkUIState.value?.selectedExpirationDate,
+                    password = _addPublicLinkUIState.value?.selectedPassword
+                )
             )
-        )
+        }
     }
 
     data class AddPublicLinkUIState(