feat: show pencil button for editing space public links

Author: joragua

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/links/SpaceLinksAdapter.kt

@@ -39,6 +39,7 @@ class SpaceLinksAdapter(
 
     private var spaceLinks: List<OCLink> = emptyList()
     private var canRemoveLinks = false
+    private var canEditLinks = false
 
     override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): SpaceLinksViewHolder {
         val inflater = LayoutInflater.from(parent.context)
@@ -78,13 +79,22 @@ class SpaceLinksAdapter(
                     listener.onRemovePublicLink(spaceLink.id, spaceLink.displayName)
                 }
             }
+
+            editPublicLinkButton.apply {
+                contentDescription = holder.itemView.context.getString(R.string.content_description_edit_public_link, spaceLink.displayName)
+                isVisible = canEditLinks
+                setOnClickListener {
+                    listener.onEditPublicLink(spaceLink)
+                }
+            }
         }
     }
 
     override fun getItemCount(): Int = spaceLinks.size
 
-    fun setSpaceLinks(spaceLinks: List<OCLink>, canRemoveLinks: Boolean) {
+    fun setSpaceLinks(spaceLinks: List<OCLink>, canRemoveLinks: Boolean, canEditLinks: Boolean) {
         this.canRemoveLinks = canRemoveLinks
+        this.canEditLinks = canEditLinks
         val diffCallback = SpaceLinksDiffUtil(this.spaceLinks, spaceLinks)
         val diffResult = DiffUtil.calculateDiff(diffCallback)
         this.spaceLinks = spaceLinks
@@ -98,5 +108,6 @@ class SpaceLinksAdapter(
     interface SpaceLinksAdapterListener {
         fun onCopyOrSendPublicLink(publicLinkUrl: String)
         fun onRemovePublicLink(publicLinkId: String, publicLinkDisplayName: String)
+        fun onEditPublicLink(publicLink: OCLink)
     }
 }

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersFragment.kt

@@ -80,7 +80,7 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
     private var spaceMembers: List<SpaceMember> = emptyList()
     private var listener: SpaceMemberFragmentListener? = null
     private var canRemoveMembersAndLinks = false
-    private var canEditMembers = false
+    private var canEditMembersAndLinks = false
     private var canReadMembers = false
     private var numberOfManagers = 1
 
@@ -112,7 +112,7 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
         currentSpace = requireArguments().getParcelable<OCSpace>(ARG_CURRENT_SPACE) ?: return
         savedInstanceState?.let {
             canRemoveMembersAndLinks = it.getBoolean(CAN_REMOVE_MEMBERS, false)
-            canEditMembers = it.getBoolean(CAN_EDIT_MEMBERS, false)
+            canEditMembersAndLinks = it.getBoolean(CAN_EDIT_MEMBERS, false)
             canReadMembers = it.getBoolean(CAN_READ_MEMBERS, false)
         }
 
@@ -158,7 +158,7 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
     override fun onSaveInstanceState(outState: Bundle) {
         super.onSaveInstanceState(outState)
         outState.putBoolean(CAN_REMOVE_MEMBERS, canRemoveMembersAndLinks)
-        outState.putBoolean(CAN_EDIT_MEMBERS, canEditMembers)
+        outState.putBoolean(CAN_EDIT_MEMBERS, canEditMembersAndLinks)
         outState.putBoolean(CAN_READ_MEMBERS, canReadMembers)
     }
 
@@ -197,6 +197,10 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
         )
     }
 
+    override fun onEditPublicLink(publicLink: OCLink) {
+
+    }
+
     private fun subscribeToViewModels() {
         observeRoles()
         observeSpaceMembers()
@@ -359,7 +363,7 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
     private fun checkPermissions(spacePermissions: List<String>) {
         val hasCreatePermission = DRIVES_CREATE_PERMISSION in spacePermissions
         canRemoveMembersAndLinks = DRIVES_DELETE_PERMISSION in spacePermissions
-        canEditMembers = DRIVES_UPDATE_PERMISSION in spacePermissions
+        canEditMembersAndLinks = DRIVES_UPDATE_PERMISSION in spacePermissions
         canReadMembers = DRIVES_READ_PERMISSION in spacePermissions
         binding.apply {
             addMemberButton.isVisible = hasCreatePermission
@@ -381,7 +385,7 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
             spaceMembers = spaceMembers,
             roles = roles,
             canRemoveMembers = canRemoveMembersAndLinks,
-            canEditMembers = canEditMembers,
+            canEditMembers = canEditMembersAndLinks,
             numberOfManagers = numberOfManagers
         )
     }
@@ -398,7 +402,8 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
                     Date(0)
                 }
             },
-            canRemoveLinks = canRemoveMembersAndLinks
+            canRemoveLinks = canRemoveMembersAndLinks,
+            canEditLinks = canEditMembersAndLinks
         )
     }
 

owncloudApp/src/main/res/layout/public_link_item.xml

@@ -122,6 +122,19 @@
             android:visibility="gone"
             tools:visibility="visible" />
 
+        <ImageButton
+            android:id="@+id/edit_public_link_button"
+            android:layout_width="40dp"
+            android:layout_height="40dp"
+            android:layout_gravity="center_vertical"
+            android:layout_marginEnd="@dimen/standard_half_margin"
+            android:padding="@dimen/standard_half_padding"
+            android:background="?android:attr/selectableItemBackground"
+            android:focusable="true"
+            android:src="@drawable/ic_lead_pencil_grey"
+            android:visibility="gone"
+            tools:visibility="visible" />
+
     </LinearLayout>
 
     <View