CR Suggestions

Author: fesave

owncloudApp/src/main/res/layout/preview_image_fragment.xml

@@ -30,40 +30,31 @@
         android:id="@+id/progressWheel"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_centerInParent="true"
         android:indeterminate="true"
         android:indeterminateOnly="true"
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintLeft_toLeftOf="parent"
         app:layout_constraintRight_toRightOf="parent"
         app:layout_constraintTop_toTopOf="parent" />
 
-    <androidx.constraintlayout.widget.Guideline
-        android:id="@+id/horizontal_guideline_50_percent"
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
-        android:orientation="horizontal"
-        app:layout_constraintGuide_percent="0.5" />
-
     <ImageView
         android:id="@+id/error_image"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_gravity="center_horizontal"
-        android:contentDescription="@string/downloader_download_failed_ticker"
+        android:contentDescription="@string/downloader_preview_failed_ticker"
         android:src="@drawable/image_fail"
-        app:layout_constraintBottom_toBottomOf="@id/horizontal_guideline_50_percent"
         app:layout_constraintLeft_toLeftOf="parent"
         app:layout_constraintRight_toRightOf="parent"
-        app:layout_constraintTop_toTopOf="@id/horizontal_guideline_50_percent" />
+        app:layout_constraintTop_toTopOf="parent"
+        app:layout_constraintBottom_toBottomOf="parent"/>
 
     <TextView
         android:id="@+id/errorText"
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_margin="40dp"
         android:gravity="center"
-        android:text="@string/downloader_download_failed_ticker"
+        android:text="@string/downloader_preview_failed_ticker"
         android:textColor="@color/dark_background_text_color"
         app:layout_constraintLeft_toLeftOf="parent"
         app:layout_constraintRight_toRightOf="parent"
@@ -94,6 +85,7 @@
     <include layout="@layout/top_progress_bar" />
 
     <androidx.constraintlayout.widget.Group
+        tools:visibility="visible"
         android:id="@+id/error_group"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"

owncloudApp/src/main/res/values/strings.xml

@@ -241,6 +241,7 @@
     <string name="downloader_download_succeeded_ticker">Download succeeded</string>
     <string name="downloader_download_succeeded_content">%1$s downloaded</string>
     <string name="downloader_download_failed_ticker">Download failed</string>
+    <string name="downloader_preview_failed_ticker">Unable to display the file</string>
     <string name="downloader_download_failed_content">Download of %1$s could not be completed</string>
     <string name="downloader_not_downloaded_yet">Not downloaded yet</string>
     <string name="downloader_download_failed_credentials_error">Download failed, you need to log in again</string>