refactor: use OCLinkType instead of String for link permission and cast before remote execution

Author: joragua

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/links/SpaceLinksViewModel.kt

@@ -70,7 +70,7 @@ class SpaceLinksViewModel(
                 accountName = accountName,
                 spaceId = space.id,
                 displayName = displayName,
-                type = OCLinkType.toString(permission),
+                type = permission,
                 expirationDate = expirationDate,
                 password = password
             )

owncloudData/src/main/java/com/owncloud/android/data/links/datasources/RemoteLinksDataSource.kt

@@ -20,6 +20,8 @@
 
 package com.owncloud.android.data.links.datasources
 
+import com.owncloud.android.domain.links.model.OCLinkType
+
 interface RemoteLinksDataSource {
-    fun addLink(accountName: String, spaceId: String, displayName: String, type: String, expirationDate: String?, password: String?)
+    fun addLink(accountName: String, spaceId: String, displayName: String, type: OCLinkType, expirationDate: String?, password: String?)
 }

owncloudData/src/main/java/com/owncloud/android/data/links/datasources/implementation/OCRemoteLinksDataSource.kt

@@ -23,12 +23,15 @@ package com.owncloud.android.data.links.datasources.implementation
 import com.owncloud.android.data.ClientManager
 import com.owncloud.android.data.executeRemoteOperation
 import com.owncloud.android.data.links.datasources.RemoteLinksDataSource
+import com.owncloud.android.domain.links.model.OCLinkType
 
 class OCRemoteLinksDataSource(
     private val clientManager: ClientManager
 ): RemoteLinksDataSource {
 
-    override fun addLink(accountName: String, spaceId: String, displayName: String, type: String, expirationDate: String?, password: String?) {
-        executeRemoteOperation { clientManager.getLinksService(accountName).addLink(spaceId, displayName, type, expirationDate, password) }
+    override fun addLink(accountName: String, spaceId: String, displayName: String, type: OCLinkType, expirationDate: String?, password: String?) {
+        executeRemoteOperation {
+            clientManager.getLinksService(accountName).addLink(spaceId, displayName, OCLinkType.toString(type), expirationDate, password)
+        }
     }
 }

owncloudData/src/main/java/com/owncloud/android/data/links/repository/OCLinksRepository.kt

@@ -22,12 +22,13 @@ package com.owncloud.android.data.links.repository
 
 import com.owncloud.android.data.links.datasources.RemoteLinksDataSource
 import com.owncloud.android.domain.links.LinksRepository
+import com.owncloud.android.domain.links.model.OCLinkType
 
 class OCLinksRepository(
     private val remoteLinksDataSource: RemoteLinksDataSource
 ): LinksRepository {
 
-    override fun addLink(accountName: String, spaceId: String, displayName: String, type: String, expirationDate: String?, password: String?) {
+    override fun addLink(accountName: String, spaceId: String, displayName: String, type: OCLinkType, expirationDate: String?, password: String?) {
         remoteLinksDataSource.addLink(accountName, spaceId, displayName, type, expirationDate, password)
     }
 }

owncloudDomain/src/main/java/com/owncloud/android/domain/links/LinksRepository.kt

@@ -20,6 +20,8 @@
 
 package com.owncloud.android.domain.links
 
+import com.owncloud.android.domain.links.model.OCLinkType
+
 interface LinksRepository {
-    fun addLink(accountName: String, spaceId: String, displayName: String, type: String, expirationDate: String?, password: String?)
+    fun addLink(accountName: String, spaceId: String, displayName: String, type: OCLinkType, expirationDate: String?, password: String?)
 }

owncloudDomain/src/main/java/com/owncloud/android/domain/links/usecases/AddLinkUseCase.kt

@@ -22,6 +22,7 @@ package com.owncloud.android.domain.links.usecases
 
 import com.owncloud.android.domain.BaseUseCaseWithResult
 import com.owncloud.android.domain.links.LinksRepository
+import com.owncloud.android.domain.links.model.OCLinkType
 
 class AddLinkUseCase(
     private val linksRepository: LinksRepository
@@ -35,7 +36,7 @@ class AddLinkUseCase(
         val accountName: String,
         val spaceId: String,
         val displayName: String,
-        val type: String,
+        val type: OCLinkType,
         val expirationDate: String?,
         val password: String?
     )