feat: php8 (#1230)

Author: DeepDiver1975

.drone.star

@@ -4,7 +4,7 @@ MINIO_MC = "minio/mc:RELEASE.2020-12-18T10-53-53Z"
 OC_CI_ALPINE = "owncloudci/alpine:latest"
 OC_CI_BAZEL_BUILDIFIER = "owncloudci/bazel-buildifier"
 OC_CI_CEPH = "owncloudci/ceph:tag-build-master-jewel-ubuntu-16.04"
-OC_CI_CORE = "owncloudci/core"
+OC_CI_CORE = "owncloudci/core:php83"
 OC_CI_DRONE_SKIP_PIPELINE = "owncloudci/drone-skip-pipeline"
 OC_CI_NODEJS = "owncloudci/nodejs:%s"
 OC_CI_ORACLE_XE = "owncloudci/oracle-xe:latest"
@@ -21,7 +21,7 @@ SELENIUM_STANDALONE_CHROME_DEBUG = "selenium/standalone-chrome-debug:3.141.59-ox
 SELENIUM_STANDALONE_FIREFOX_DEBUG = "selenium/standalone-firefox-debug:3.8.1"
 SONARSOURCE_SONAR_SCANNER_CLI = "sonarsource/sonar-scanner-cli"
 
-DEFAULT_PHP_VERSION = "7.4"
+DEFAULT_PHP_VERSION = "8.3"
 DEFAULT_NODEJS_VERSION = "14"
 
 # minio mc environment variables
@@ -53,18 +53,12 @@ config = {
     "branches": [
         "master",
     ],
-    "codestyle": True,
+    "codestyle": False,
     "validateDailyTarball": True,
-    "phpstan": True,
-    "phan": {
-        "multipleVersions": {
-            "phpVersions": [
-                DEFAULT_PHP_VERSION,
-            ],
-        },
-    },
-    "javascript": True,
-    "phpunit": True,
+    "phpstan": False,
+    "phan": False,
+    "javascript": False,
+    "phpunit": False,
     "acceptance": {
         "webUI": {
             "suites": {

.github/workflows/main.yml

@@ -0,0 +1,66 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    types:
+      - opened
+      - synchronize
+      - reopened
+
+permissions:
+  contents: read
+
+concurrency:
+  group: lint-${{ github.ref }}
+  cancel-in-progress: true
+
+env:
+  APP_NAME: activity
+  PHP_VERSIONS: '["8.3"]'
+
+jobs:
+  get-vars:
+    runs-on: ubuntu-latest
+    outputs:
+      app-name: ${{ env.APP_NAME }}
+      php-versions: ${{ env.PHP_VERSIONS }}
+    steps:
+      - name: Set variables
+        run: |
+          echo "App name $APP_NAME"
+          echo "PHP versions string: $PHP_VERSIONS"
+
+  semantic-git-messages:
+    name: Commits
+    uses: owncloud/reusable-workflows/.github/workflows/semantic-git-message.yml@main
+
+  php-code-style:
+    name: PHP Code Style
+    needs:
+      - get-vars
+    uses: owncloud/reusable-workflows/.github/workflows/php-codestyle.yml@main
+    with:
+      app-name: ${{ needs.get-vars.outputs.app-name }}
+      php-versions: ${{ needs.get-vars.outputs.php-versions }}
+
+  php-unit:
+    name: PHP Unit
+    needs:
+      - get-vars
+    uses: owncloud/reusable-workflows/.github/workflows/php-unit.yml@main
+    with:
+      app-name: ${{ needs.get-vars.outputs.app-name }}
+      php-versions: ${{ needs.get-vars.outputs.php-versions }}
+
+
+  js-unit:
+    name: JS Unit
+    needs:
+      - get-vars
+    uses: owncloud/reusable-workflows/.github/workflows/js-unit.yml@main
+    with:
+      app-name: ${{ needs.get-vars.outputs.app-name }}
+      php-version: '8.3'

.scrutinizer.yml

@@ -30,7 +30,8 @@ Never again miss an important event related to content in ownCloud and always be
   <screenshot>https://raw.githubusercontent.com/owncloud/screenshots/68550c2b7c53e6309132ca1c7b177adca976db0b/activity/activity.png</screenshot>
   <category>tools</category>
   <dependencies>
-    <owncloud min-version="10.15" max-version="11" />
+    <owncloud min-version="11" max-version="11" />
+    <php min-version="8.3" />
   </dependencies>
   <background-jobs>
     <job>OCA\Activity\BackgroundJob\EmailNotification</job>

appinfo/info.xml

@@ -2,13 +2,14 @@
   "name": "owncloud/activity",
   "config" : {
     "platform": {
-      "php": "7.3"
+      "php": "8.3"
     },
     "allow-plugins": {
       "bamarni/composer-bin-plugin": true
     }
   },
   "require": {
+    "php": ">=8.3"
   },
   "require-dev": {
     "bamarni/composer-bin-plugin": "^1.8"

composer.json

@@ -61,7 +61,7 @@ class EmailNotification extends TimedJob {
 	 * @param bool|null $isCLI
 	 */
 	public function __construct(
-		?MailQueueHandler $mailQueueHandler = null,
+		?MailQueueHandler $mailQueueHandler,
 		IUserManager $userManager,
 		?IConfig $config = null,
 		?ILogger $logger = null,

composer.lock

@@ -1,5 +1,5 @@
 {
     "require": {
-        "owncloud/coding-standard": "^5.1"
+        "owncloud/coding-standard": "^5.3"
     }
 }