Skip to content

Commit 96ce99d

Browse files
Merge pull request #30506 from QiWang19/extend-waittime
OCPNODE-3877: Update grace period for cluster upgrade to 10 minutes
2 parents 484f6c0 + c17e560 commit 96ce99d

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

test/e2e/upgrade/upgrade.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,7 @@ func clusterUpgrade(f *framework.Framework, c configv1client.Interface, dc dynam
620620

621621
var errMasterUpdating error
622622
var violationStartTime *time.Time
623-
const gracePeriod = 2 * time.Minute
623+
const gracePeriod = 10 * time.Minute
624624

625625
if err := disruption.RecordJUnit(
626626
f,
@@ -666,10 +666,11 @@ func clusterUpgrade(f *framework.Framework, c configv1client.Interface, dc dynam
666666
framework.Logf("Invariant violation detected: master pool requires update but nodes not ready. Waiting up to %v for non-draining updates to complete", gracePeriod)
667667
return false, nil
668668
}
669-
if time.Since(*violationStartTime) <= gracePeriod {
669+
waitTime := time.Since(*violationStartTime)
670+
if waitTime <= gracePeriod {
670671
return false, nil
671672
}
672-
errMasterUpdating = fmt.Errorf("the %q pool should be updated before the CVO reports available at the new version", p.GetName())
673+
errMasterUpdating = fmt.Errorf("the %q pool should be updated before the CVO reports available at the new version (nodes still not ready after %v wait time, grace period: %v)", p.GetName(), waitTime.Round(time.Second), gracePeriod)
673674
framework.Logf("Invariant violation detected: %s", errMasterUpdating)
674675
}
675676
}

0 commit comments

Comments
 (0)