Skip to content

Commit 2b2156b

Browse files
Merge pull request #30720 from eggfoobar/skip-commatrix-twonode
OCPEDGE-2355: feat: skip unsupported commatrix tests for two node
2 parents 2dfa4fd + 17e6dd1 commit 2b2156b

2 files changed

Lines changed: 17 additions & 4 deletions

File tree

test/extended/networking/commatrix.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ import (
1717

1818
"github.com/openshift-kni/commatrix/pkg/types"
1919
configv1 "github.com/openshift/api/config/v1"
20+
exutil "github.com/openshift/origin/test/extended/util"
2021
clientOptions "sigs.k8s.io/controller-runtime/pkg/client"
2122

2223
"github.com/openshift-kni/commatrix/pkg/client"
@@ -47,11 +48,10 @@ var (
4748
)
4849

4950
var _ = Describe("[sig-network][Feature:commatrix][apigroup:config.openshift.io][Serial]", func() {
51+
oc := exutil.NewCLI("")
52+
5053
BeforeEach(func() {
51-
kubeconfig := os.Getenv("KUBECONFIG")
52-
if kubeconfig == "" {
53-
Fail("KUBECONFIG not set")
54-
}
54+
skipUnsupportedControlPlaneTopology(oc)
5555

5656
By("Creating output folder")
5757
artifactsDir = os.Getenv("ARTIFACT_DIR")

test/extended/networking/util.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1040,3 +1040,16 @@ func runOcWithRetryIgnoreOutput(oc *exutil.CLI, cmd string, args ...string) erro
10401040
_, err := runOcWithRetry(oc, cmd, args...)
10411041
return err
10421042
}
1043+
1044+
func skipUnsupportedControlPlaneTopology(oc *exutil.CLI) {
1045+
controlPlane, err := exutil.GetControlPlaneTopology(oc)
1046+
if err != nil || controlPlane == nil {
1047+
e2e.Logf("Failed : failed to get control plane topology, errored(%v) or controlPlane was nil", err)
1048+
return
1049+
}
1050+
1051+
switch *controlPlane {
1052+
case configv1.DualReplicaTopologyMode, configv1.HighlyAvailableArbiterMode:
1053+
Skip(fmt.Sprintf("Unsupported control plane topology, skipping (%v)", *controlPlane))
1054+
}
1055+
}

0 commit comments

Comments
 (0)