You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: remove escapeHTML() misapplied to .textContent sinks
Self-review caught that the defense-in-depth escapeHTML() calls added
for #179 wrapped values assigned via .textContent, not .innerHTML.
.textContent never interprets HTML, so escaping there adds no security
value while risking visible text corruption (a literal "&" shown
on screen) if the underlying value ever contains a special character.
toEmbedUrl()'s URL-origin validation is the real, load-bearing fix and
is unaffected by this change — it guarantees embedUrl can only ever be
'' or a well-formed https://youtube.com|vimeo.com URL regardless of
which DOM property ultimately consumes it.
0 commit comments