Build gettext. Gives us libintl.a. Will prevent glib from building libintl.so

Author: ViliusSutkus89

3rdparty/EPHelpers.cmake

@@ -25,6 +25,13 @@ function(FilterDependsList DEPENDS_LIST)
           endif()
         endif()
 
+      elseif("${DEPENDENCY}" STREQUAL "gettext")
+        # gettext does not have pkg-config.pc. Just check if the it exists.
+        # libintl.a is the interesting part.
+        if (NOT EXISTS ${THIRDPARTY_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}intl${CMAKE_STATIC_LIBRARY_SUFFIX})
+          message(FATAL_ERROR "Missing dependency ${DEPENDENCY}!")
+        endif()
+
       else()
         pkg_check_modules(LIBNAME REQUIRED ${DEPENDENCY})
       endif()

3rdparty/packages/FixGettextSource.sh

@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+set -euo pipefail
+GETTEXT_SRC=$1
+
+#libcroco/cr-statement.c:2661:32: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
+#fprintf (a_fp, str) ;
+
+# gettext wtf? Why U doing this???
+
+sed -i 's/fprintf (a_fp, str)/fprintf (a_fp, "%s", str)/g' $GETTEXT_SRC/libtextstyle/gnulib-local/lib/libcroco/cr-statement.c
+sed -i 's/fprintf (a_fp, str)/fprintf (a_fp, "%s", str)/g' $GETTEXT_SRC/libtextstyle/lib/libcroco/cr-statement.c

3rdparty/packages/FixGlibInstall.sh

@@ -0,0 +1,22 @@
+#!/bin/bash
+set -euo pipefail
+
+THIRDPARTY_PREFIX=$1
+PC_FILE=${THIRDPARTY_PREFIX}/lib/pkgconfig/glib-2.0.pc
+
+
+echo "Before patching"
+cat $PC_FILE
+
+# glib uses libintl
+# Currently, pkg-config.pc tells linker to first link libintl.a and only then libglib.a
+# That is bad, because libintl.a is a static lib, and whatever symbols it provides will not
+# be included when requested by the the libglib.a
+
+sed -i 's/Libs: -lintl/Libs:/g' $PC_FILE
+sed -i '/Libs:/s/$/ -lintl/' $PC_FILE
+
+echo ""
+
+echo "After patching"
+cat $PC_FILE

3rdparty/packages/gettext.cmake

@@ -0,0 +1,31 @@
+include_guard(GLOBAL)
+
+# gettext doesn't provide pkg-config .pc
+# Check if build is needed, before calling to EPAutotools
+
+# We only building gettext for libintl.a, so that is what we are checking
+if (EXISTS ${THIRDPARTY_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}intl${CMAKE_STATIC_LIBRARY_SUFFIX})
+  return()
+endif ()
+
+ExternalProjectAutotools(gettext
+  DEPENDS iconv libxml-2.0
+  URL https://ftp.gnu.org/pub/gnu/gettext/gettext-0.20.1.tar.gz
+  URL_HASH SHA256=66415634c6e8c3fa8b71362879ec7575e27da43da562c798a8a2f223e6e47f5c
+  CONFIGURE_ARGUMENTS
+    --disable-java
+    --disable-libasprintf
+    --disable-curses
+    --disable-namespacing
+    --disable-openmp
+    --disable-acl
+  EXTRA_ARGUMENTS
+    UPDATE_COMMAND
+    # libcroco/cr-statement.c:2661:32: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
+                #fprintf (a_fp, str) ;
+    # gettext wtf? Why U doing this???
+    ${CMAKE_CURRENT_SOURCE_DIR}/packages/FixGettextSource.sh
+    ${CMAKE_CURRENT_BINARY_DIR}/gettext-prefix/src/gettext/
+
+    LOG_UPDATE 1
+)

3rdparty/packages/glib-2.0.cmake

@@ -1,8 +1,14 @@
 include_guard(GLOBAL)
 
 ExternalProjectMeson(glib-2.0
-  DEPENDS libffi iconv
+  DEPENDS libffi iconv gettext
   URL https://ftp.gnome.org/pub/gnome/sources/glib/2.61/glib-2.61.1.tar.xz
   URL_HASH SHA256=f8d827955f0d8e197ff5c2105dd6ac4f6b63d15cd021eb1de66534c92a762161
   CONFIGURE_ARGUMENTS -Dlibmount=false
+
+  EXTRA_ARGUMENTS
+  # glib uses libintl (from gettext), but the glib-2.0.pc is wrong
+  # libintl.a needs to be included after libglib-2.0
+  TEST_COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/packages/FixGlibInstall.sh ${THIRDPARTY_PREFIX}
+  LOG_TEST 1
 )