Skip to content

Commit 4ad455f

Browse files
Move native code for Fontconfig instrumented tests into libpdf2htmlEX.so
1 parent d629c9f commit 4ad455f

4 files changed

Lines changed: 5 additions & 15 deletions

File tree

pdf2htmlEX/build.gradle

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,6 @@ android {
4545
buildTypes.release.externalNativeBuild {
4646
cmake.arguments '-DCMAKE_BUILD_TYPE=MinSizeRel'
4747
}
48-
packagingOptions {
49-
exclude 'lib/*/libnativeFontconfigInstrumentedTests.so'
50-
}
5148
externalNativeBuild.cmake {
5249
path "src/main/cpp/CMakeLists.txt"
5350
version "3.10.2"

pdf2htmlEX/src/androidTest/java/com/viliussutkus89/android/pdf2htmlex/FontconfigInstrumentedTests.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,6 @@
3434

3535
@RunWith(AndroidJUnit4.class)
3636
public class FontconfigInstrumentedTests {
37-
static {
38-
System.loadLibrary("nativeFontconfigInstrumentedTests");
39-
}
40-
4137
//pdf base14 fonts:
4238
//Courier, Courier Bold, Courier Oblique, Courier Bold-Oblique
4339
//Helvetica, Helvetica Bold, Helvetica Oblique, Helvetica Bold-Oblique
@@ -114,5 +110,5 @@ public synchronized void matchDingbatsTest() {
114110
assertEquals("d050000l.pfb", getFontFilenameFromFontconfig("Zapf Dingbats"));
115111
}
116112

117-
private native String getFontFilenameFromFontconfig(String pattern);
113+
public static native String getFontFilenameFromFontconfig(String pattern);
118114
}

pdf2htmlEX/src/main/cpp/CMakeLists.txt

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ pkg_search_module(pdf2htmlEX REQUIRED pdf2htmlEX)
3030

3131
link_directories(${pdf2htmlEX_LIBRARY_DIRS})
3232

33-
add_library(pdf2htmlEX-android SHARED pdf2htmlEX.cc)
33+
add_library(pdf2htmlEX-android SHARED pdf2htmlEX.cc
34+
FontconfigAndroid.cc)
3435

3536
target_link_libraries(pdf2htmlEX-android
3637
${CMAKE_CURRENT_LIST_DIR}/../../../build/tmpfile/jni/${ANDROID_ABI}/libtmpfile.so
@@ -40,8 +41,3 @@ target_link_libraries(pdf2htmlEX-android
4041
set_target_properties(pdf2htmlEX-android PROPERTIES COMPILE_FLAGS ${pdf2htmlEX_CFLAGS})
4142
target_include_directories(pdf2htmlEX-android PRIVATE ${pdf2htmlEX_INCLUDE_DIRS})
4243

43-
add_library(nativeFontconfigInstrumentedTests SHARED nativeFontconfigInstrumentedTests.cpp)
44-
target_link_libraries(nativeFontconfigInstrumentedTests ${pdf2htmlEX_LIBRARIES})
45-
46-
set_target_properties(nativeFontconfigInstrumentedTests PROPERTIES COMPILE_FLAGS ${pdf2htmlEX_CFLAGS})
47-
target_include_directories(nativeFontconfigInstrumentedTests PRIVATE ${pdf2htmlEX_INCLUDE_DIRS})

pdf2htmlEX/src/main/cpp/nativeFontconfigInstrumentedTests.cpp renamed to pdf2htmlEX/src/main/cpp/FontconfigAndroid.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
extern "C"
55
JNIEXPORT jstring JNICALL
66
Java_com_viliussutkus89_android_pdf2htmlex_FontconfigInstrumentedTests_getFontFilenameFromFontconfig(
7-
JNIEnv *env, jobject, jstring pattern_) {
7+
JNIEnv *env, jclass, jstring pattern_) {
88
const char * pattern = env->GetStringUTFChars(pattern_, nullptr);
99
FcFontSet *fs = FcFontSetCreate();
1010
FcPattern *pat = FcNameParse (reinterpret_cast<const FcChar8 *>(pattern));
@@ -36,3 +36,4 @@ Java_com_viliussutkus89_android_pdf2htmlex_FontconfigInstrumentedTests_getFontFi
3636
FcFini ();
3737
return matchedFilename ? matchedFilename : env->NewStringUTF("");
3838
}
39+

0 commit comments

Comments
 (0)