Skip to content

Commit 496d5b8

Browse files
Use libffi-3.3-rc0 for armeabi-v7a
1 parent 4a79665 commit 496d5b8

2 files changed

Lines changed: 16 additions & 11 deletions

File tree

3rdparty/packages/glib-2.0.cmake

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,7 @@
11
include_guard(GLOBAL)
22

3-
# armeabi-v7a fails to build libffi. However, glib-2.0 manages to build it internally.
4-
SET(LIBFFI_DEPENDENCY libffi)
5-
if(ANDROID_ABI STREQUAL armeabi-v7a)
6-
SET(LIBFFI_DEPENDENCY)
7-
endif()
8-
93
ExternalProjectMeson(glib-2.0
10-
DEPENDS iconv libintl ${LIBFFI_DEPENDENCY}
4+
DEPENDS iconv libintl zlib libffi
115
URL https://ftp.gnome.org/pub/gnome/sources/glib/2.61/glib-2.61.1.tar.xz
126
URL_HASH SHA256=f8d827955f0d8e197ff5c2105dd6ac4f6b63d15cd021eb1de66534c92a762161
137
CONFIGURE_ARGUMENTS -Dlibmount=false

3rdparty/packages/libffi.cmake

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,17 @@
11
include_guard(GLOBAL)
22

3-
ExternalProjectAutotools(libffi
4-
URL ftp://sourceware.org/pub/libffi/libffi-3.2.1.tar.gz
5-
URL_HASH SHA256=d06ebb8e1d9a22d19e38d63fdb83954253f39bedc5d46232a05645685722ca37
6-
)
3+
# libffi-3.2.1 fails to build on armeabi-v7a ABI
4+
# https://github.com/libffi/libffi/issues/478
5+
# Use 3.3-rc0
6+
7+
if(ANDROID_ABI STREQUAL armeabi-v7a)
8+
ExternalProjectAutotools(libffi
9+
URL https://github.com/libffi/libffi/releases/download/v3.3-rc0/libffi-3.3-rc0.tar.gz
10+
URL_HASH SHA256=403d67aabf1c05157855ea2b1d9950263fb6316536c8c333f5b9ab1eb2f20ecf
11+
)
12+
else()
13+
ExternalProjectAutotools(libffi
14+
URL ftp://sourceware.org/pub/libffi/libffi-3.2.1.tar.gz
15+
URL_HASH SHA256=d06ebb8e1d9a22d19e38d63fdb83954253f39bedc5d46232a05645685722ca37
16+
)
17+
endif()

0 commit comments

Comments
 (0)