Skip to content

Commit 5796674

Browse files
authored
Merge pull request #359 from opendocument-app/release-240709
upgrade dependencies, raise version
2 parents d3b46e6 + f5ce66d commit 5796674

6 files changed

Lines changed: 14 additions & 11 deletions

File tree

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,3 +66,5 @@ app/lite/release/
6666
fastlane/report.xml
6767

6868
.idea/
69+
70+
app/CMakeUserPresets.json

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,4 @@ More information at https://opendocument.app/ and in the app itself.
1515
## Setup
1616

1717
- `conan remote add odr https://artifactory.opendocument.app/artifactory/api/conan/conan`
18+
- make sure `conan` is in your $PATH or replace conan-call in `app/build.gradle`

app/build.gradle

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ android {
4343
defaultConfig {
4444
applicationId "at.tomtasche.reader"
4545
minSdkVersion 23
46-
targetSdkVersion 33
4746
compileSdkVersion 34
47+
targetSdkVersion 34
4848

4949
testApplicationId "at.tomtasche.reader.test"
5050
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
@@ -139,18 +139,18 @@ android {
139139
}
140140

141141
dependencies {
142-
implementation platform('com.google.firebase:firebase-bom:33.0.0')
142+
implementation platform('com.google.firebase:firebase-bom:33.1.1')
143143
implementation 'com.google.firebase:firebase-storage'
144144
implementation 'com.google.firebase:firebase-auth'
145145
implementation 'com.google.firebase:firebase-crashlytics-ndk'
146146
implementation 'com.google.firebase:firebase-analytics'
147147
implementation 'com.google.firebase:firebase-config'
148148

149-
implementation 'com.google.android.gms:play-services-ads:23.1.0'
150-
implementation 'com.google.android.play:core:1.10.3'
149+
implementation 'com.google.android.gms:play-services-ads:23.2.0'
150+
implementation 'com.google.android.play:review:2.0.1'
151151
implementation 'com.google.android.ump:user-messaging-platform:2.2.0'
152152

153-
implementation 'androidx.appcompat:appcompat:1.6.1'
153+
implementation 'androidx.appcompat:appcompat:1.7.0'
154154
implementation 'androidx.core:core:1.13.1'
155155
implementation 'com.google.android.material:material:1.12.0'
156156
implementation 'androidx.webkit:webkit:1.11.0'
@@ -167,4 +167,4 @@ dependencies {
167167
// espresso-idling-resource is used in main sourceSet as well. cannot be just androidTestImplementation
168168
implementation 'androidx.test.espresso:espresso-idling-resource:3.5.1'
169169
implementation 'androidx.annotation:annotation:1.8.0'
170-
}
170+
}

app/src/main/AndroidManifest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
33
xmlns:tools="http://schemas.android.com/tools"
44
android:installLocation="auto"
5-
android:versionCode="179"
6-
android:versionName="3.26"
5+
android:versionCode="181"
6+
android:versionName="3.28"
77
tools:ignore="GoogleAppIndexingWarning">
88

99
<uses-permission android:name="android.permission.INTERNET" />

app/src/main/java/at/tomtasche/reader/ui/activity/DocumentFragment.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,13 +319,13 @@ private void requestInAppRating(Activity activity) {
319319
analyticsManager.report("in_app_review_eligible");
320320

321321
ReviewManager manager = ReviewManagerFactory.create(activity);
322-
com.google.android.play.core.tasks.Task<ReviewInfo> request = manager.requestReviewFlow();
322+
com.google.android.gms.tasks.Task<ReviewInfo> request = manager.requestReviewFlow();
323323
request.addOnCompleteListener(reviewInfoTask -> {
324324
if (reviewInfoTask.isSuccessful()) {
325325
analyticsManager.report("in_app_review_start");
326326

327327
ReviewInfo reviewInfo = reviewInfoTask.getResult();
328-
com.google.android.play.core.tasks.Task<Void> flow = manager.launchReviewFlow(activity, reviewInfo);
328+
com.google.android.gms.tasks.Task<Void> flow = manager.launchReviewFlow(activity, reviewInfo);
329329
flow.addOnCompleteListener(reviewTask -> {
330330
analyticsManager.report("in_app_review_done");
331331
});

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
plugins {
2-
id 'com.android.application' version '8.4.0' apply false
2+
id 'com.android.application' version '8.4.1' apply false
33
id 'com.google.gms.google-services'version '4.4.1' apply false
44
id 'com.google.firebase.crashlytics' version '3.0.1' apply false
55
}

0 commit comments

Comments
 (0)