PyVO docs use ADQL reserved word in table upload docs

[fajpunk]

The PyVO table upload docs use the ADQL reserved word count as a column name in their table upload example: https://pyvo.readthedocs.io/en/latest/dal/index.html#uploads. This returns an error: Identifier 'count' is a reserved keyword. I think the right thing to do here is to change the PyVO docs to not use ADQL reserved words as column names. It seems like that is not supported against a youcat server.

I just want to make sure there is not some youcat configuration that I'm missing that would allow that PyVO example to work. If not, then I will make a PR to update the PyVO docs.

[pdowler]

The increased strictness of validation in youcat is recent and we arbitrarily decided to stop allowing reserved words to be used. There are existing tables in the CADC youcat servcie with invalid identifiers and we plan to work with users (table owners) to fix those.

So, I agree that the docs/examples should be fixed to not encourage this bad practice that is likely to behave inconsistently and/or fail. The next TAP standard will be more clear on such requirements.

[pdowler]

In fact, that increased strictness in validation applies also to TAP UPLOAD in any TAP service using the cadc-tap-schema and cadc-tap-server libraries, so also the CADC's argus service (CAOM) and the TAP service in RSP.

[fajpunk]

Thank you! I've submitted a PR to update the PyVO docs.