From 89365747a56c41541bc87e85a213059ca245cea8 Mon Sep 17 00:00:00 2001
From: aaronmrice <372839+aaronmrice@users.noreply.github.com>
Date: Tue, 21 Oct 2025 23:22:55 -0700
Subject: [PATCH] autoinstall.sh: change format of `sudo tee` invocations

The original code tells the shell to invoke `cat` and `sudo tee`, pipe a
message into cat's stdin, pipe cat's stdout (that same message) into
tee's stdin, which then has elevated privileges to write to disk.

We can skip the middleman of `cat` and pipe the message directly into
`sudo tee`'s stdin.
---
 autoinstall.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/autoinstall.sh b/autoinstall.sh
index fe03af5e..374b2b82 100644
--- a/autoinstall.sh
+++ b/autoinstall.sh
@@ -57,7 +57,7 @@ update_os() {
 # Function to create and configure the autoconnect script
 configure_autoconnect_script() {
   # Create connectall.py file
-  cat <<EOF | sudo tee /usr/local/bin/connectall.py > /dev/null
+  sudo tee /usr/local/bin/connectall.py > /dev/null <<EOF
 #!/usr/bin/python3
 import subprocess
 
@@ -89,7 +89,7 @@ EOF
   execute_command "sudo service udev restart"
 
   # Create midi.service file
-  cat <<EOF | sudo tee /lib/systemd/system/midi.service > /dev/null
+  sudo tee /lib/systemd/system/midi.service > /dev/null <<EOF
 [Unit]
 Description=Initial USB MIDI connect
 
@@ -142,7 +142,7 @@ install_piano_led_visualizer() {
   execute_command "cd Piano-LED-Visualizer"
   execute_command "sudo pip3 install -r requirements.txt --break-system-packages" "check_internet"
   execute_command "sudo raspi-config nonint do_boot_behaviour B2"
-  cat <<EOF | sudo tee /lib/systemd/system/visualizer.service > /dev/null
+  sudo tee /lib/systemd/system/visualizer.service > /dev/null <<EOF
 [Unit]
 Description=Piano LED Visualizer
 After=network-online.target