Skip to content

Issues on Statamic 1.7.5 #1

Description

@agarone-mm

A few issues in trying to get this plugin up and running for a Statamic newbie like myself:

  • It would be nice in the readme to see installation instructions:
    • Create /_add-ons/commentatic/
    • Put pi.commentatic.php in /_add-ons/commentatic/
    • Put commentatic.yaml.sample in /_config/add-ons/
  • Line 245 in pi.commentatic.php refers to Statamic_helper::resolve_path(), which seems like it should be be Path::resolve() in 1.7.5
  • Lines 82 and 97 refer to Statamic::get_site_root(), which seems like it should be Config::getSiteRoot() in 1.7.5
  • Lines 107 and 169 refer to $this->parse_loop(), which appears to have been deprecated and replaced with Parse::tagLoop()

In my local copy, I've made these replacements, but I don't think it's completely functioning yet. I'm guessing there are other deprecated methods to be updated. If I find anything or fix anything, I'll post a comment.

Thanks for putting this together!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions