From 3bff8805ab2de3d75eec45f6ca0e2ea2285998dc Mon Sep 17 00:00:00 2001 From: sepehr-safari Date: Tue, 28 Jul 2026 18:41:44 +0300 Subject: [PATCH] chore: size scenario changesets as patch, not minor The changeset from #133 was a minor, so the pending release PR proposed 0.5.0. That number is reserved for OCPP 2.0.1 in both ROADMAP.md and CURRENT_STATE.md, and spending it on one new scenario would push the 2.0.1 work to 0.6.0 and break the milestone-to-version mapping the project has held since v0.1. Retags the pending changeset to patch, so the release recomputes to 0.4.3. Adds the convention to the "Adding a Scenario" section, which did not mention changesets at all. A new scenario does add a public export, but scenarios are test corpus rather than consumer API surface: nothing is built against an individual scenario constant, and the registry is consumed as a whole through scenarios and getScenario(). #133 was asked for a minor during review, and #137, #138 and #139 are queued behind it. Closes #142 --- .changeset/warm-dragons-smile.md | 2 +- CONTRIBUTING.md | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.changeset/warm-dragons-smile.md b/.changeset/warm-dragons-smile.md index d39165b..dd9326e 100644 --- a/.changeset/warm-dragons-smile.md +++ b/.changeset/warm-dragons-smile.md @@ -1,5 +1,5 @@ --- -"@ocpp-debugkit/toolkit": minor +"@ocpp-debugkit/toolkit": patch --- feat(scenarios): add firmware update success scenario diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 72b0042..e884071 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -238,6 +238,14 @@ trace with expected failure outcomes and optional assertions. check from [Verify Locally](#4-verify-locally). `ocpp-debugkit ci` does not cover formatting, lint, or types. +5. Add a changeset with `pnpm changeset`, and pick **patch**. A new scenario does + add a public export, but scenarios are test corpus rather than consumer API + surface: nothing is built against an individual scenario constant, and the + registry is consumed as a whole through `scenarios` and `getScenario()`. + Minor and major releases are reserved for changes to the analysis engine, so + version numbers keep lining up with the milestones in + [ROADMAP.md](ROADMAP.md). + ### Guidelines - All data must be **synthetic** — no real station IDs, transaction IDs, idTags,