diff --git a/scripts/facade-delegation-registry.json b/scripts/facade-delegation-registry.json index d20e850db32..4dd766d44f2 100644 --- a/scripts/facade-delegation-registry.json +++ b/scripts/facade-delegation-registry.json @@ -20,380 +20,380 @@ { "file": "packages/metadata-protocol/src/protocol.ts", "member": "getDiscovery", - "card": "#30020", - "reason": "inferred-return-type (#29985 report: stays on the class)" + "card": "#30054", + "reason": "inferred-return-type (#29985 report: stays on the class until the return type is spelled)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "findData", - "card": "#30020", - "reason": "inferred-return-type (#29985 report: stays on the class)" + "card": "#30054", + "reason": "inferred-return-type (#29985 report: stays on the class until the return type is spelled)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "getData", - "card": "#30020", - "reason": "inferred-return-type (#29985 report: stays on the class)" + "card": "#30054", + "reason": "inferred-return-type (#29985 report: stays on the class until the return type is spelled)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "cloneData", - "card": "#30020", - "reason": "inferred-return-type (#29985 report: stays on the class)" + "card": "#30054", + "reason": "inferred-return-type (#29985 report: stays on the class until the return type is spelled)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "saveMetaItem", - "card": "#30020", - "reason": "inferred-return-type (#29985 report: stays on the class)" + "card": "#30054", + "reason": "inferred-return-type (#29985 report: stays on the class until the return type is spelled)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "publishMetaItem", - "card": "#30020", - "reason": "inferred-return-type (#29985 report: stays on the class)" + "card": "#30054", + "reason": "inferred-return-type (#29985 report: stays on the class until the return type is spelled)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "rollbackMetaItem", - "card": "#30020", - "reason": "inferred-return-type (#29985 report: stays on the class)" + "card": "#30054", + "reason": "inferred-return-type (#29985 report: stays on the class until the return type is spelled)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "deleteMetaItem", - "card": "#30020", - "reason": "inferred-return-type (#29985 report: stays on the class)" + "card": "#30054", + "reason": "inferred-return-type (#29985 report: stays on the class until the return type is spelled)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "publishPackageDrafts", "card": "#30020", - "reason": "closed-set (#29985 report)" + "reason": "state-owning: closed-set, a bare `this` (not `this.`) hands the instance itself on (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "reconcileViewExpansions", - "card": "#30020", - "reason": "closed-set (#29985 report)" + "card": "#30147", + "reason": "codemod limit: closed-set, reads the private static field `registeredViewExpansions` (only a called private static method is in the closed set) (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "packagelessOverlayWriteRefusal", - "card": "#30020", - "reason": "closed-set (#29985 report)" + "card": "#30147", + "reason": "codemod limit: closed-set, a local named `host` would shadow the host parameter; name-taken (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "namedBaseOverlayWriteRefusal", - "card": "#30020", - "reason": "closed-set (#29985 report)" + "card": "#30147", + "reason": "codemod limit: closed-set, a local named `host` would shadow the host parameter; name-taken (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "static mergesOverlayAtRead", - "card": "#30020", - "reason": "static-reads-class (#29985 report)" + "card": "#30147", + "reason": "codemod limit: static-reads-class, a private static that reads `this` (the class) (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "static registryAllowsOverlay", - "card": "#30020", - "reason": "static-reads-class (#29985 report)" + "card": "#30147", + "reason": "codemod limit: static-reads-class, a private static that reads `this` (the class) (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "static isOverlayAllowed", - "card": "#30020", - "reason": "static-reads-class (#29985 report)" + "card": "#30147", + "reason": "codemod limit: static-reads-class, a private static that reads `this` (the class) (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "static isRuntimeCreateAllowed", - "card": "#30020", - "reason": "static-reads-class (#29985 report)" + "card": "#30147", + "reason": "codemod limit: static-reads-class, a private static that reads `this` (the class) (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "static codeOnlySourceHint", - "card": "#30020", - "reason": "static-reads-class (#29985 report)" + "card": "#30147", + "reason": "codemod limit: static-reads-class, a private static that names the class (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "static codeOnlyCreateError", - "card": "#30020", - "reason": "static-reads-class (#29985 report)" + "card": "#30147", + "reason": "codemod limit: static-reads-class, a private static that names the class (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "static codeOnlyOverrideError", - "card": "#30020", - "reason": "static-reads-class (#29985 report)" + "card": "#30147", + "reason": "codemod limit: static-reads-class, a private static that names the class (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "static refuseOrganizationScopedWrite", - "card": "#30020", - "reason": "static-reads-class (#29985 report)" + "card": "#30147", + "reason": "codemod limit: static-reads-class, a private static that reads `this` (the class) (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "static overlayPackageMismatchError", - "card": "#30020", - "reason": "static-reads-class (#29985 report)" + "card": "#30147", + "reason": "codemod limit: static-reads-class, a private static that names the class (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "rethrowUnlessMetadataStoreUnprovisioned", - "card": "#30020", - "reason": "no-host-read (#29985 report)" + "card": "#30147", + "reason": "codemod limit: no-host-read, the body reads no member, so the moved function would leave its host parameter unread (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "triggerAutomation", - "card": "#30020", - "reason": "no-host-read (#29985 report)" + "card": "#30147", + "reason": "codemod limit: no-host-read, the body reads no member, so the moved function would leave its host parameter unread (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "objectExtensionItemRefusal", - "card": "#30020", - "reason": "name-taken (#29985 report)" + "card": "#30147", + "reason": "codemod limit: name-taken, its name is already a module-scope binding of protocol.ts (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "packagedBaseRefusal", - "card": "#30020", - "reason": "host-entry-predicate (#29985 report)" + "card": "#30147", + "reason": "codemod limit: host-entry-predicate, it reaches the type predicate isPackagedBaseRefusal through a host entry not yet written (#29985 report)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "applySeedBodies", "card": "#30020", - "reason": "gate reading: a hand-series host slot computes (optional-call service lookup)" + "reason": "state-owning: gate reading, a hand-series host slot computes (optional-call service lookup); the hand-series host rule is #30020's" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "static OVERLAY_ALLOWED_TYPES", - "card": "#30020", - "reason": "gate reading: a static table built in an initializer body at class load" + "card": "#30147", + "reason": "codemod limit: gate reading, a static table built in an initializer body at class load (a pure function of imports; the initializer can move to a module)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "static STATIC_REGISTRY_TYPES", - "card": "#30020", - "reason": "gate reading: a static table built in an initializer body at class load" + "card": "#30147", + "reason": "codemod limit: gate reading, a static table built in an initializer body at class load (a pure function of imports; the initializer can move to a module)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "static RUNTIME_CREATE_ALLOWED_TYPES", - "card": "#30020", - "reason": "gate reading: a static table built in an initializer body at class load" + "card": "#30147", + "reason": "codemod limit: gate reading, a static table built in an initializer body at class load (a pure function of imports; the initializer can move to a module)" }, { "file": "packages/metadata-protocol/src/protocol.ts", "member": "static OVERLAY_CAPABLE_TYPES", - "card": "#30020", - "reason": "gate reading: a static table built in an initializer body at class load" + "card": "#30147", + "reason": "codemod limit: gate reading, a static table built in an initializer body at class load (a pure function of imports; the initializer can move to a module)" }, { "file": "packages/objectql/src/engine.ts", "member": "update", "card": "#30020", - "reason": "bare-this (#29986 report: stays on the class)" + "reason": "state-owning: bare-this, the body hands the instance itself on (#29986 report: stays on the class)" }, { "file": "packages/objectql/src/engine.ts", "member": "insert", "card": "#30020", - "reason": "bare-this (#29986 report: stays on the class)" + "reason": "state-owning: bare-this, the body hands the instance itself on (#29986 report: stays on the class)" }, { "file": "packages/objectql/src/engine.ts", "member": "delete", "card": "#30020", - "reason": "bare-this (#29986 report: stays on the class)" + "reason": "state-owning: bare-this, the body hands the instance itself on (#29986 report: stays on the class)" }, { "file": "packages/objectql/src/engine.ts", "member": "find", "card": "#30020", - "reason": "bare-this (#29986 report: stays on the class)" + "reason": "state-owning: bare-this, the body hands the instance itself on (#29986 report: stays on the class)" }, { "file": "packages/objectql/src/engine.ts", "member": "findOne", "card": "#30020", - "reason": "bare-this (#29986 report: stays on the class)" + "reason": "state-owning: bare-this, the body hands the instance itself on (#29986 report: stays on the class)" }, { "file": "packages/objectql/src/engine.ts", "member": "recomputeSummaries", "card": "#30020", - "reason": "bare-this (#29986 report: stays on the class)" + "reason": "state-owning: bare-this, the body hands the instance itself on (#29986 report: stays on the class)" }, { "file": "packages/objectql/src/engine.ts", "member": "resolveReadableIdsSecurity", "card": "#30020", - "reason": "bare-this (#29986 report: stays on the class)" + "reason": "state-owning: bare-this, the body hands the instance itself on (#29986 report: stays on the class)" }, { "file": "packages/objectql/src/engine.ts", "member": "bindHooks", "card": "#30020", - "reason": "bare-this (#29986 report: stays on the class)" + "reason": "state-owning: bare-this, the body hands the instance itself on (#29986 report: stays on the class)" }, { "file": "packages/objectql/src/engine.ts", "member": "readMigrationFlagRowMemoized", "card": "#30020", - "reason": "bare-this (#29986 report: stays on the class)" + "reason": "state-owning: bare-this, the body hands the instance itself on (#29986 report: stays on the class)" }, { "file": "packages/objectql/src/engine.ts", "member": "createContext", "card": "#30020", - "reason": "bare-this (#29986 report: stays on the class)" + "reason": "state-owning: bare-this, the body hands the instance itself on (#29986 report: stays on the class)" }, { "file": "packages/objectql/src/engine.ts", "member": "ownershipQueueService", "card": "#30020", - "reason": "bare-this (#29986 report: stays on the class)" + "reason": "state-owning: bare-this, the body hands the instance itself on (#29986 report: stays on the class)" }, { "file": "packages/objectql/src/engine.ts", "member": "buildHookApi", "card": "#30020", - "reason": "bare-this (#29986 report: stays on the class)" + "reason": "state-owning: bare-this, the body hands the instance itself on (#29986 report: stays on the class)" }, { "file": "packages/objectql/src/engine.ts", "member": "registerApp", - "card": "#30020", - "reason": "inferred-return-type (#29986 report)" + "card": "#30054", + "reason": "inferred-return-type (#29986 report: stays on the class until the return type is spelled)" }, { "file": "packages/objectql/src/engine.ts", "member": "registerHook", - "card": "#30020", - "reason": "inferred-return-type (#29986 report)" + "card": "#30054", + "reason": "inferred-return-type (#29986 report: stays on the class until the return type is spelled)" }, { "file": "packages/objectql/src/engine.ts", "member": "registerDriver", - "card": "#30020", - "reason": "inferred-return-type (#29986 report)" + "card": "#30054", + "reason": "inferred-return-type (#29986 report: stays on the class until the return type is spelled)" }, { "file": "packages/objectql/src/engine.ts", "member": "init", - "card": "#30020", - "reason": "inferred-return-type (#29986 report)" + "card": "#30054", + "reason": "inferred-return-type (#29986 report: stays on the class until the return type is spelled)" }, { "file": "packages/objectql/src/engine.ts", "member": "triggerHooks", - "card": "#30020", - "reason": "inferred-return-type (#29986 report)" + "card": "#30054", + "reason": "inferred-return-type (#29986 report: stays on the class until the return type is spelled)" }, { "file": "packages/objectql/src/engine.ts", "member": "destroy", - "card": "#30020", - "reason": "inferred-return-type (#29986 report)" + "card": "#30054", + "reason": "inferred-return-type (#29986 report: stays on the class until the return type is spelled)" }, { "file": "packages/objectql/src/engine.ts", "member": "setDatasourceMapping", - "card": "#30020", - "reason": "inferred-return-type (#29986 report)" + "card": "#30054", + "reason": "inferred-return-type (#29986 report: stays on the class until the return type is spelled)" }, { "file": "packages/objectql/src/engine.ts", "member": "getStatus", - "card": "#30020", - "reason": "inferred-return-type (#29986 report)" + "card": "#30054", + "reason": "inferred-return-type (#29986 report: stays on the class until the return type is spelled)" }, { "file": "packages/objectql/src/engine.ts", "member": "seedAutonumber", - "card": "#30020", - "reason": "query-options erasure pin, baseline keyed by path (#29986 report)" + "card": "#30055", + "reason": "query-options erasure pin, baseline keyed by path (#29986 report: moves once the #4918 sites are typed)" }, { "file": "packages/objectql/src/engine.ts", "member": "probeReferencingRows", - "card": "#30020", - "reason": "query-options erasure pin, baseline keyed by path (#29986 report)" + "card": "#30055", + "reason": "query-options erasure pin, baseline keyed by path (#29986 report: moves once the #4918 sites are typed)" }, { "file": "packages/objectql/src/engine.ts", "member": "resolveMasterDetailParent", - "card": "#30020", - "reason": "query-options erasure pin, baseline keyed by path (#29986 report)" + "card": "#30055", + "reason": "query-options erasure pin, baseline keyed by path (#29986 report: moves once the #4918 sites are typed)" }, { "file": "packages/objectql/src/engine.ts", "member": "resolveMasterDetailParents", - "card": "#30020", - "reason": "query-options erasure pin, baseline keyed by path (#29986 report)" + "card": "#30055", + "reason": "query-options erasure pin, baseline keyed by path (#29986 report: moves once the #4918 sites are typed)" }, { "file": "packages/objectql/src/engine.ts", "member": "inspectDanglingReferences", - "card": "#30020", - "reason": "query-options erasure pin, baseline keyed by path (#29986 report)" + "card": "#30055", + "reason": "query-options erasure pin, baseline keyed by path (#29986 report: moves once the #4918 sites are typed)" }, { "file": "packages/objectql/src/engine.ts", "member": "referenceExists", - "card": "#30020", - "reason": "query-options erasure pin, baseline keyed by path (#29986 report)" + "card": "#30055", + "reason": "query-options erasure pin, baseline keyed by path (#29986 report: moves once the #4918 sites are typed)" }, { "file": "packages/objectql/src/engine.ts", "member": "homeAmountServing", - "card": "#30020", - "reason": "field-call (#29986 report)" + "card": "#30147", + "reason": "codemod limit: field-call, it calls a field or accessor as a function (#29986 report)" }, { "file": "packages/objectql/src/engine.ts", "member": "constructor", "card": "#30020", - "reason": "gate reading: constructor logic (a fallback and a branch on an env flag)" + "reason": "state-owning: gate reading, constructor logic (a fallback and a branch on an env flag)" }, { "file": "packages/objectql/src/engine.ts", "member": "projectHomeAmountsOntoPatch", - "card": "#30020", - "reason": "gate reading: a parameter default computes (calls this.homeAmountServing)" + "card": "#30147", + "reason": "codemod limit: gate reading, a parameter default computes (calls this.homeAmountServing)" }, { "file": "packages/objectql/src/engine.ts", "member": "serveReferenceNames", "card": "#30020", - "reason": "gate reading: a hand-series host slot holds a try block" + "reason": "state-owning: gate reading, a hand-series host slot holds a try block; the hand-series host rule is #30020's" }, { "file": "packages/drivers/driver-sql/src/sql-driver.ts", "member": "constructor", "card": "#30020", - "reason": "gate reading: constructor logic (strips the ObjectStack options off the config, branches on fileColumnsMoved, builds Knex; the state is the instance's)" + "reason": "state-owning: gate reading, constructor logic (strips the ObjectStack options off the config, branches on fileColumnsMoved, builds Knex; the state is the instance's)" }, { "file": "packages/drivers/driver-sql/src/sql-driver.ts", "member": "logger", - "card": "#30020", - "reason": "gate reading: the default sink's field initializer holds arrow functions (state owned by the instance)" + "card": "#30147", + "reason": "codemod limit: gate reading, the default sink's field initializer holds arrow functions (the default can be built by a module function)" }, { "file": "packages/drivers/driver-sql/src/sql-driver.ts", "member": "static DIALECT_CONNECT_TIMEOUT", - "card": "#30020", - "reason": "gate reading: a static table whose initializer holds arrow functions (state owned by the class)" + "card": "#30147", + "reason": "codemod limit: gate reading, a static table whose initializer holds arrow functions (the initializer can move to a module)" }, { "file": "packages/drivers/driver-sql/src/sql-driver.ts", @@ -519,7 +519,7 @@ "file": "packages/drivers/driver-sql/src/sql-driver.ts", "member": "applyFilters", "card": "#30147", - "reason": "inferred-return-type (#30105 report: stays on the class)" + "reason": "inferred-return-type (#30105 report: stays on the class until the codemod spells the return type)" }, { "file": "packages/drivers/driver-sql/src/sql-driver.ts", @@ -531,13 +531,13 @@ "file": "packages/drivers/driver-sql/src/sql-driver.ts", "member": "ensureDatabaseExists", "card": "#30147", - "reason": "inferred-return-type (#30105 report: stays on the class)" + "reason": "inferred-return-type (#30105 report: stays on the class until the codemod spells the return type)" }, { "file": "packages/drivers/driver-sql/src/sql-driver.ts", "member": "createDatabase", "card": "#30147", - "reason": "inferred-return-type (#30105 report: stays on the class)" + "reason": "inferred-return-type (#30105 report: stays on the class until the codemod spells the return type)" }, { "file": "packages/drivers/driver-sql/src/sql-driver.ts",