Skip to content

Commit cfd88e7

Browse files
committed
chore(console): name the Skills-docs follow-up card; keep the filter field's docblock on its function
Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01L6bhgXa2W2ZCA4huS5hVVx
1 parent 4699b9f commit cfd88e7

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎.changeset/28370-view-filter-or-group-console.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ feat(console): a stored view filter's OR group filters the list, and the filter
1010

1111
Clause-②: yes (widening: `@object-ui/core` adds the export `builderRulesOfSpecFilter` and its result type `BuilderFilterRules`; no schema, accept set or error code changes)
1212
Metadata-protocol: none
13-
Skills-docs: follow-up owed — skills/objectstack-ui/rules/list-views.md, skills/objectstack-ui/evals/views-apps-actions-pages.json (the any-of group is not taught there yet); `content/docs/ui/views.mdx` gains a Base filter section that states it
13+
Skills-docs: follow-up #28476 — skills/objectstack-ui/rules/list-views.md, skills/objectstack-ui/evals/views-apps-actions-pages.json (the any-of group is not taught there yet); `content/docs/ui/views.mdx` gains a Base filter section that states it
1414

1515
A view filter list may hold an any-of group beside its rules, `{ or: [rule, ...] }` (`ViewFilterOrGroupSchema` in `@objectstack/spec/ui`): the list ANDs its elements and the group ORs its rules. Until now no console reader applied it. The list query passed the group through, the server refused the query as a malformed filter (400 `INVALID_FILTER`), and the view showed no rows.
1616

‎ui/packages/app-shell/src/views/metadata-admin/inspectors/PageBlockInspector.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,15 +59,15 @@ function useFieldOptions(objectName: string | undefined): Array<{ value: string;
5959
);
6060
}
6161

62+
/** The elements `FilterBuilderField` reads and writes. */
63+
type FilterElements = NonNullable<React.ComponentProps<typeof FilterBuilderField>['value']>;
64+
6265
/**
6366
* A block prop that is a spec view filter list (`record:related_list.filter`:
6467
* flat rules, any of which may be an any-of group `{ or: [rule, ...] }`), edited with the list toolbar's own filter builder — the one the
6568
* `filter-builder` form widget renders for a view's and a page's filters — over
6669
* the fields of `objectName`. Clearing the last rule removes the key.
6770
*/
68-
/** The elements `FilterBuilderField` reads and writes. */
69-
type FilterElements = NonNullable<React.ComponentProps<typeof FilterBuilderField>['value']>;
70-
7171
function FilterRulesField({ label, objectName, value, onChange, disabled }: {
7272
label: string; objectName: string | undefined; value: unknown;
7373
onChange: (v: FilterElements | undefined) => void;

0 commit comments

Comments
 (0)