fix(nx-cloud): adjust string templating

Author: s-wojciechowski

README.md

@@ -7,6 +7,13 @@ This repo contains:
 * Nx Cloud Helm Chart
 * Nx Agents Helm Chart
 
+> Important: Breaking changes in nx-cloud chart version 1.0.0
+>
+> Starting with chart version 1.0.0, there are breaking changes to values and templates. Please review the migration guide before upgrading and plan for required adjustments.
+>
+> See charts/nx-cloud/MIGRATION.md for details: [MIGRATION.md](charts/nx-cloud/MIGRATION.md)
+
+
 ### Compatibility Matrix
 
 | Chart Version | Compatible Images                  |

charts/nx-cloud/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: nx-cloud
 description: Nx Cloud Helm Chart
 type: application
-version: 1.0.0
+version: 1.0.1-rc1
 maintainers:
   - name: nx
     url: "https://nx.app/"

charts/nx-cloud/README.md

@@ -7,7 +7,16 @@ Controller service for Nx Agents).
 >
 > Starting with chart version 1.0.0, there are breaking changes to values and templates. Please review the migration guide before upgrading and plan for required adjustments.
 >
-> See MIGRATION.md for details: ./MIGRATION.md
+> See MIGRATION.md for details: [MIGRATION.md](MIGRATION.md)
+
+## Prerequisites
+* MongoDB 7+
+* Valkey 7.2+
+* S3-compatible storage / Google Cloud Storage / Azure Blob Storage (recommended) **OR** built-in file server (not recommended for production)
+
+## Object storage
+We recommend using a S3-compatible storage / Google Cloud Storage / Azure Blob Storage for production deployments.
+However, if you do not have a storage solution available, you can enable the built-in file server by setting `fileServer.enabled` to `true`.
 
 ## Values
 

charts/nx-cloud/templates/additional-manifests.yaml

@@ -1,8 +1,8 @@
 {{ range $name, $manifest := .Values.extraObjects }}
 ---
-{{ if typeIs "string" $manifest }}
-    {{- tpl $manifest $ }}
+{{- if typeIs "string" $manifest }}
+{{- $manifest }}
 {{- else }}
-    {{- tpl (toYaml $manifest) $ }}
+{{- toYaml $manifest }}
 {{- end }}
 {{ end }}

charts/nx-cloud/templates/configs/valkey-configmap.yaml

@@ -7,11 +7,11 @@ metadata:
     {{- include "nxCloud.mergedLabels" (dict "resourceLabels" .Values.api.deployment.labels "context" .) | nindent 4 }}
 data:
   USE_VALKEY: "true"
-  VALKEY_CLIENT_PROVIDER: "{{ .Values.api.valkey.clientProvider }}"
-  VALKEY_USE_SENTINEL: "{{ ternary "true" "false" .Values.api.valkey.useSentinel }}"
-  VALKEY_SENTINEL_MASTER_NAME: "{{ .Values.api.valkey.sentinelMasterName }}"
-  VALKEY_PRIMARY_ADDRESS: "{{ .Values.api.valkey.primaryAddress }}"
-  VALKEY_REPLICA_ADDRESSES: "{{ .Values.api.valkey.replicaAddresses }}"
-  VALKEY_PORT: "{{ .Values.api.valkey.port }}"
-  VALKEY_SENTINEL_PORT: "{{ .Values.api.valkey.sentinelPort }}"
-  VALKEY_USERNAME: "{{ .Values.api.valkey.username }}"
+  VALKEY_CLIENT_PROVIDER: {{ .Values.api.valkey.clientProvider | quote }}
+  VALKEY_USE_SENTINEL: {{ ternary "true" "false" .Values.api.valkey.useSentinel | quote }}
+  VALKEY_SENTINEL_MASTER_NAME: {{ .Values.api.valkey.sentinelMasterName | quote }}
+  VALKEY_PRIMARY_ADDRESS: {{ .Values.api.valkey.primaryAddress | quote }}
+  VALKEY_REPLICA_ADDRESSES: {{ .Values.api.valkey.replicaAddresses | quote }}
+  VALKEY_PORT: {{ .Values.api.valkey.port | quote }}
+  VALKEY_SENTINEL_PORT: {{ .Values.api.valkey.sentinelPort | quote }}
+  VALKEY_USERNAME: {{ .Values.api.valkey.username | quote }}