vfs: unflag

Signed-off-by: Matteo Collina <hello@matteocollina.com>

Author: mcollina

doc/api/cli.md

@@ -285,7 +285,7 @@ so mounting one is gated on its own flag rather than on `--allow-fs-read` or
 `--allow-fs-write`.
 
 ```console
-$ node --experimental-vfs --permission --allow-fs-vfs app.js
+$ node --permission --allow-fs-vfs app.js
 ```
 
 ### `--allow-fs-write`
@@ -1671,16 +1671,6 @@ with AND, so a test must satisfy every expression to run.
 A malformed expression causes the test runner to exit with a non-zero status
 before running any tests.
 
-### `--experimental-vfs`
-
-<!-- YAML
-added: v26.4.0
--->
-
-> Stability: 1 - Experimental
-
-Enable the experimental [`node:vfs`][] module.
-
 ### `--experimental-vm-modules`
 
 <!-- YAML
@@ -3793,7 +3783,7 @@ added: REPLACEME
 
 * `source` {string} A directory or an archive file to mount and run.
 
-Requires [`--experimental-vfs`][]. May be given at most once.
+May be given at most once.
 
 Mounts `source` exactly as [`--vfs-mount`][] does, and additionally runs the
 entry point and all subsequent `require()`/`import` resolution against that
@@ -3817,8 +3807,8 @@ the command line's decision, and the environment must not be able to redirect
 it.
 
 ```console
-$ node --experimental-vfs --vfs-load=app.zip
-$ node --experimental-vfs --vfs-mount=lib.zip --vfs-load=app.zip
+$ node --vfs-load=app.zip
+$ node --vfs-mount=lib.zip --vfs-load=app.zip
 ```
 
 ### `--vfs-mount=source`
@@ -3829,7 +3819,7 @@ added: REPLACEME
 
 * `source` {string} A directory or an archive file to mount.
 
-Requires [`--experimental-vfs`][]. May be repeated to mount several sources.
+May be repeated to mount several sources.
 
 Mounts `source` as a virtual file system ([`node:vfs`][]). Each mount is placed
 at a reserved mount point assigned by Node.js, so mounts never shadow real
@@ -3839,7 +3829,7 @@ point; use [`--vfs-load`][] for the source to run from.
 `--vfs-mount` and [`--vfs-load`][] mount in the order they are written, so
 
 ```console
-$ node --experimental-vfs --vfs-mount=a --vfs-load=b --vfs-mount=c
+$ node --vfs-mount=a --vfs-load=b --vfs-mount=c
 ```
 
 mounts `a`, `b` and `c` in that order and runs `b`. Mounts contributed by
@@ -4180,7 +4170,6 @@ one is included in the list below.
 * `--experimental-stream-iter`
 * `--experimental-test-isolation`
 * `--experimental-top-level-await`
-* `--experimental-vfs`
 * `--experimental-vm-modules`
 * `--experimental-wasi-unstable-preview1`
 * `--experimental-web-worker`
@@ -4813,7 +4802,6 @@ node --stack-trace-limit=12 -p -e "Error.stackTraceLimit" # prints 12
 [`--env-file-if-exists`]: #--env-file-if-existsfile
 [`--env-file`]: #--env-filefile
 [`--experimental-sea-config`]: single-executable-applications.md#1-generating-single-executable-preparation-blobs
-[`--experimental-vfs`]: #--experimental-vfs
 [`--heap-prof-dir`]: #--heap-prof-dir
 [`--import`]: #--importmodule
 [`--no-require-module`]: #--no-require-module

doc/api/vfs.md

@@ -24,8 +24,8 @@ import vfs from 'node:vfs';
 const vfs = require('node:vfs');
 ```
 
-This module is only available under the `node:` scheme, and only when Node.js
-is started with the `--experimental-vfs` flag.
+This module is only available under the `node:` scheme. Loading it emits an
+`ExperimentalWarning`.
 
 ## Security
 
@@ -77,8 +77,9 @@ added: v26.4.0
 * `provider` {VirtualProvider} The provider to use. **Default:**
   `new MemoryProvider()`.
 * `options` {Object}
-  * `emitExperimentalWarning` {boolean} Whether to emit the experimental
-    warning when the instance is created. **Default:** `true`.
+  * `emitExperimentalWarning` {boolean} Whether to emit an experimental warning
+    when an instance is created. **Default:** `true`. Loading `node:vfs` emits
+    the warning regardless of this option.
 * Returns: {VirtualFileSystem}
 
 Convenience factory equivalent to `new VirtualFileSystem(provider, options)`.
@@ -148,7 +149,7 @@ vfs.registerProvider({
 ```
 
 ```console
-$ node --experimental-vfs --require ./provider.js \
+$ node --require ./provider.js \
        --vfs-load archive.customfmt
 ```
 
@@ -170,8 +171,9 @@ added: v26.4.0
 * `provider` {VirtualProvider} The provider to use. **Default:**
   `new MemoryProvider()`.
 * `options` {Object}
-  * `emitExperimentalWarning` {boolean} Whether to emit the experimental
-    warning. **Default:** `true`.
+  * `emitExperimentalWarning` {boolean} Whether to emit an experimental warning
+    when an instance is created. **Default:** `true`. Loading `node:vfs` emits
+    the warning regardless of this option.
 
 ### `vfs.mount()`
 

doc/node.1

@@ -174,7 +174,7 @@ A mounted VFS serves paths that the file system permissions do not describe,
 so mounting one is gated on its own flag rather than on \fB--allow-fs-read\fR or
 \fB--allow-fs-write\fR.
 .Bd -literal
-$ node --experimental-vfs --permission --allow-fs-vfs app.js
+$ node --permission --allow-fs-vfs app.js
 .Ed
 .
 .It Fl -allow-fs-write
@@ -896,9 +896,6 @@ with AND, so a test must satisfy every expression to run.
 A malformed expression causes the test runner to exit with a non-zero status
 before running any tests.
 .
-.It Fl -experimental-vfs
-Enable the experimental \fBnode:vfs\fR module.
-.
 .It Fl -experimental-vm-modules
 Enable experimental ES Module support in the \fBnode:vm\fR module.
 .
@@ -1887,7 +1884,7 @@ Print node's version.
 .It
 \fBsource\fR \fB{string}\fR A directory or an archive file to mount and run.
 .El
-Requires \fB--experimental-vfs\fR. May be given at most once.
+May be given at most once.
 Mounts \fBsource\fR exactly as \fB--vfs-mount\fR does, and additionally runs the
 entry point and all subsequent \fBrequire()\fR/\fBimport\fR resolution against that
 mount rather than the real file system. The entry point is taken from the mount
@@ -1905,23 +1902,23 @@ same mounts, in the same order, and runs its own entry point.
 the command line's decision, and the environment must not be able to redirect
 it.
 .Bd -literal
-$ node --experimental-vfs --vfs-load=app.zip
-$ node --experimental-vfs --vfs-mount=lib.zip --vfs-load=app.zip
+$ node --vfs-load=app.zip
+$ node --vfs-mount=lib.zip --vfs-load=app.zip
 .Ed
 .
 .It Fl -vfs-mount Ns = Ns Ar source
 .Bl -bullet
 .It
 \fBsource\fR \fB{string}\fR A directory or an archive file to mount.
 .El
-Requires \fB--experimental-vfs\fR. May be repeated to mount several sources.
+May be repeated to mount several sources.
 Mounts \fBsource\fR as a virtual file system (\fBnode:vfs\fR). Each mount is placed
 at a reserved mount point assigned by Node.js, so mounts never shadow real
 paths and no target can be chosen. Mounting alone does not change the entry
 point; use \fB--vfs-load\fR for the source to run from.
 \fB--vfs-mount\fR and \fB--vfs-load\fR mount in the order they are written, so
 .Bd -literal
-$ node --experimental-vfs --vfs-mount=a --vfs-load=b --vfs-mount=c
+$ node --vfs-mount=a --vfs-load=b --vfs-mount=c
 .Ed
 mounts \fBa\fR, \fBb\fR and \fBc\fR in that order and runs \fBb\fR. Mounts contributed by
 \fBNODE_OPTIONS\fR are mounted before the command line's.
@@ -2192,8 +2189,6 @@ one is included in the list below.
 .It
 \fB--experimental-top-level-await\fR
 .It
-\fB--experimental-vfs\fR
-.It
 \fB--experimental-vm-modules\fR
 .It
 \fB--experimental-wasi-unstable-preview1\fR

lib/internal/process/pre_execution.js

@@ -262,7 +262,6 @@ function finishVfsMounts() {
 
   const entries = getOptionValue('--vfs-mount');
   if (entries.length === 0) return;
-  emitExperimentalWarning('--vfs-mount');
 
   const fs = require('fs');
   const path = require('path');
@@ -288,7 +287,7 @@ function finishVfsMounts() {
     if (provider === null) {
       throw new ERR_VFS_INVALID_TARGET(resolvedSource);
     }
-    const vfs = new VirtualFileSystem(provider, { emitExperimentalWarning: false });
+    const vfs = new VirtualFileSystem(provider);
     const mountPoint = vfs.mount();
     // The mount --vfs-load contributed is what the entry is require()d from;
     // process.argv[1] names the real source instead, since the reserved mount
@@ -559,10 +558,6 @@ function setupQuic() {
 }
 
 function setupVfs() {
-  if (!getOptionValue('--experimental-vfs')) {
-    return;
-  }
-
   const { BuiltinModule } = require('internal/bootstrap/realm');
   BuiltinModule.allowRequireByUsers('vfs');
 }

lib/internal/vfs/file_system.js

@@ -13,7 +13,6 @@ const {
     ERR_INVALID_STATE,
   },
 } = require('internal/errors');
-const { validateBoolean } = require('internal/validators');
 const { MemoryProvider } = require('internal/vfs/providers/memory');
 const path = require('path');
 const { posix: pathPosix, resolve: resolvePath, sep, toNamespacedPath } = path;
@@ -35,6 +34,7 @@ const {
 const { VirtualReadStream, VirtualWriteStream } = require('internal/vfs/streams');
 const { VirtualDir } = require('internal/vfs/dir');
 const { emitExperimentalWarning, kEmptyObject } = require('internal/util');
+const { validateBoolean } = require('internal/validators');
 let debug = require('internal/util/debuglog').debuglog('vfs', (fn) => {
   debug = fn;
 });
@@ -94,7 +94,6 @@ class VirtualFileSystem {
   /**
    * @param {VirtualProvider|object} [providerOrOptions] The provider to use, or options
    * @param {object} [options] Configuration options
-   * @param {boolean} [options.emitExperimentalWarning] Emit the experimental warning (default: true)
    */
   constructor(providerOrOptions, options = kEmptyObject) {
     let provider = null;

lib/internal/vfs/sea.js

@@ -41,8 +41,7 @@ function initSeaVfs(options = kEmptyObject) {
   const { SEAProvider } = require('internal/vfs/providers/sea');
 
   const provider = new SEAProvider({ extraFiles: options.extraFiles });
-  // The SEA warning already covers the feature; don't emit the
-  // VirtualFileSystem experimental warning for the implicit SEA mount.
+  // SEA has its own experimental warning; don't emit another for this mount.
   const vfs = new VirtualFileSystem(provider, {
     emitExperimentalWarning: false,
   });

lib/vfs.js

@@ -4,6 +4,9 @@ const {
   FunctionPrototypeSymbolHasInstance,
 } = primordials;
 
+const { emitExperimentalWarning } = require('internal/util');
+emitExperimentalWarning('VirtualFileSystem');
+
 const { VirtualFileSystem } = require('internal/vfs/file_system');
 const { VirtualProvider } = require('internal/vfs/provider');
 const { MemoryProvider } = require('internal/vfs/providers/memory');

src/node.cc

@@ -1036,22 +1036,8 @@ static ExitCode InitializeNodeWithArgsInternal(
   CheckGlobalBenchOptions(errors);
   if (!errors->empty()) return ExitCode::kInvalidCommandLineArgument;
 
-  // Checked here rather than in EnvironmentOptions::CheckOptions(), which runs
-  // at the end of every parse: NODE_OPTIONS is parsed before the command line,
-  // so a check there would reject `NODE_OPTIONS=--vfs-mount=x node
-  // --experimental-vfs` for an --experimental-vfs it had not read yet. These
-  // options only make sense as a set, so they are validated once all of them
-  // are in.
   {
     auto* env_options = per_process::cli_options->per_isolate->per_env.get();
-    if (!env_options->experimental_vfs) {
-      if (!env_options->vfs_mounts.empty()) {
-        errors->push_back("--vfs-mount requires --experimental-vfs");
-      }
-      if (env_options->vfs_load) {
-        errors->push_back("--vfs-load requires --experimental-vfs");
-      }
-    }
     // --vfs-load shares vfs_mounts with --vfs-mount, so the options themselves
     // cannot say how often it was given; count it in the node options the
     // command line yielded. A second one would silently win over the first.

src/node_options.cc

@@ -687,8 +687,9 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
             NoOp{},
 #endif
             kAllowedInEnvvar);
+  // Retained as a no-op for compatibility; node:vfs is no longer experimental.
   AddOption("--experimental-vfs",
-            "experimental node:vfs module",
+            "",
             BOOL_FIELD(experimental_vfs),
             kAllowedInEnvvar);
   // --vfs-mount and --vfs-load both append to vfs_mounts, so the list holds
@@ -697,7 +698,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
   // rather than an index the user has to count out.
   AddOption("--vfs-mount",
             "mount a directory or archive as a virtual file system "
-            "(option can be repeated; requires --experimental-vfs)",
+            "(option can be repeated)",
             &EnvironmentOptions::vfs_mounts,
             kAllowedInEnvvar);
   // Choosing the entry point is the command line's alone: an environment
@@ -706,7 +707,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
   AddOption("--vfs-load",
             "mount a directory or archive as a virtual file system and run the "
             "entry point and module resolution against it instead of the real "
-            "file system (may be given once; requires --experimental-vfs)",
+            "file system (may be given once)",
             &EnvironmentOptions::vfs_mounts,
             kDisallowedInEnvvar);
   AddOption("[vfs_load_set]", "", BOOL_FIELD(vfs_load));

test/ffi/test-ffi-vfs.js

@@ -1,4 +1,4 @@
-// Flags: --experimental-vfs
+// Flags: --disable-warning=ExperimentalWarning
 'use strict';
 const common = require('../common');
 common.skipIfFFIMissing();