Skip to content

Commit 7680075

Browse files
committed
Revert "inspector: fix null request_queue dereference in InspectorIo"
This reverts commit 9e4757a. Signed-off-by: Aaron Lichtman <alichtman@meta.com>
1 parent 9e4757a commit 7680075

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

‎src/inspector_io.cc‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,7 @@ std::unique_ptr<InspectorIo> InspectorIo::Start(
250250
path,
251251
host_port,
252252
inspect_publish_uid));
253-
if (io->request_queue_ == nullptr ||
254-
io->request_queue_->Expired()) { // Thread is not running
253+
if (io->request_queue_->Expired()) { // Thread is not running
255254
return nullptr;
256255
}
257256
return io;
@@ -273,8 +272,7 @@ InspectorIo::InspectorIo(std::shared_ptr<MainThreadHandle> main_thread,
273272
}
274273

275274
InspectorIo::~InspectorIo() {
276-
if (request_queue_ != nullptr)
277-
request_queue_->Post(0, TransportAction::kKill, nullptr);
275+
request_queue_->Post(0, TransportAction::kKill, nullptr);
278276
int err = uv_thread_join(&thread_);
279277
CHECK_EQ(err, 0);
280278
}

0 commit comments

Comments
 (0)