Skip to content

Commit 79de32c

Browse files
committed
Added some comments. This commit marks 3.0.6!
1 parent f858c43 commit 79de32c

File tree

4 files changed

+13
-11
lines changed

4 files changed

+13
-11
lines changed

App/SupportFiles/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
</dict>
3535
</array>
3636
<key>CFBundleVersion</key>
37-
<string>24030</string>
37+
<string>24031</string>
3838
<key>LSApplicationCategoryType</key>
3939
<string>public.app-category.utilities</string>
4040
<key>NSHumanReadableCopyright</key>

Helper/Core/Actions/Actions.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ + (void)executeActionArray:(NSArray *)actionArray phase:(MFActionPhase)phase {
6161
/// Choose the `bfmethod`
6262
/// Mnemonic: (method) for going (b)ack and (f)orward
6363

64-
NSString *bundleID = [HelperUtility appUnderMousePointerWithEvent: NULL].bundleIdentifier;
64+
NSString *bundleID = [HelperUtility appUnderMousePointerWithEvent: NULL].bundleIdentifier; /// [Aug 2025] Should we query frontmost app or app-under-mouse-pointer? I think navigation swipes only work when the app is frontmost *and* the mouse pointer is over the desired view. Meanwhile the keyboard shortcuts dont depend on mouse pointer position.
6565
#define isbundle(bundleid) [bundleID hasPrefix: @bundleid] /** [Aug 2025] Using `hasPrefix:` to also catch other release channels like "com.google.Chrome.canary", or maybe forks that didn't bother to change the bundleID. (?) */
6666
{
6767
/// Fallback if we can't retrieve a bundleID
@@ -219,6 +219,8 @@ static void postKeyboardShortcut(CGKeyCode keyCode, CGSModifierFlags modifierFla
219219
/// Even when you pass a CGEventSource with the desired keyboardType, CGEventCreateKeyboardEvent() just overrides it. It seems like a bug in CoreGraphics.
220220
/// In practise this messes up the 'Universal Back and Forward' feature we're building, cause `MFEmulateNSMenuItemRemapping()` assumes `MFKeyboardTypeCurrent()` when calculating the vkc that will trigger the shortcut.
221221
/// Observed on: macOS 15.5, 2018 Mac Mini, [Aug 2025]
222+
///
223+
/// ! Keep this when merging with __EventLoggerForBrad__.
222224
{
223225

224226
/// Definitions copied over from SymbolicHotKeys.m [Aug 2025]

Helper/SupportFiles/Info.plist

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<key>CFBundleShortVersionString</key>
2020
<string>$(MARKETING_VERSION)</string>
2121
<key>CFBundleVersion</key>
22-
<string>24030</string>
22+
<string>24031</string>
2323
<key>LSApplicationCategoryType</key>
2424
<string>public.app-category.utilities</string>
2525
<key>LSBackgroundOnly</key>

Mouse Fix.xcodeproj/xcuserdata/Noah.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -775,8 +775,8 @@
775775
filePath = "Helper/Core/Actions/SymbolicHotKeys.m"
776776
startingColumnNumber = "9223372036854775807"
777777
endingColumnNumber = "9223372036854775807"
778-
startingLineNumber = "690"
779-
endingLineNumber = "690"
778+
startingLineNumber = "691"
779+
endingLineNumber = "691"
780780
landmarkName = "MFEmulateNSMenuItemRemapping(vkc, modifierMask)"
781781
landmarkType = "9">
782782
</BreakpointContent>
@@ -791,8 +791,8 @@
791791
filePath = "Helper/Core/Actions/SymbolicHotKeys.m"
792792
startingColumnNumber = "9223372036854775807"
793793
endingColumnNumber = "9223372036854775807"
794-
startingLineNumber = "689"
795-
endingLineNumber = "689"
794+
startingLineNumber = "690"
795+
endingLineNumber = "690"
796796
landmarkName = "MFEmulateNSMenuItemRemapping(vkc, modifierMask)"
797797
landmarkType = "9">
798798
</BreakpointContent>
@@ -807,8 +807,8 @@
807807
filePath = "Helper/Core/Actions/SymbolicHotKeys.m"
808808
startingColumnNumber = "9223372036854775807"
809809
endingColumnNumber = "9223372036854775807"
810-
startingLineNumber = "771"
811-
endingLineNumber = "771"
810+
startingLineNumber = "772"
811+
endingLineNumber = "772"
812812
landmarkName = "MFEmulateNSMenuItemRemapping(vkc, modifierMask)"
813813
landmarkType = "9">
814814
</BreakpointContent>
@@ -852,8 +852,8 @@
852852
filePath = "Helper/Core/Actions/Actions.m"
853853
startingColumnNumber = "9223372036854775807"
854854
endingColumnNumber = "9223372036854775807"
855-
startingLineNumber = "238"
856-
endingLineNumber = "238"
855+
startingLineNumber = "240"
856+
endingLineNumber = "240"
857857
landmarkName = "postKeyboardShortcut(keyCode, modifierFlags)"
858858
landmarkType = "9">
859859
</BreakpointContent>

0 commit comments

Comments
 (0)