chore(common): add smoke test bash script for ci

Author: nickchecan

Makefile

@@ -6,7 +6,7 @@ ROOT_DIR := $(CURDIR)
 BUILDPACK_DIR := $(ROOT_DIR)
 PYTHON_BIN ?= python3
 
-.PHONY: test-buildpack clean-test-buildpack start-local
+.PHONY: test-buildpack clean-test-buildpack smoke-test start-local
 
 # Reset the temporary staging directories used for local buildpack testing.
 clean-test-buildpack:
@@ -17,15 +17,22 @@ clean-test-buildpack:
 test-buildpack: clean-test-buildpack
 	mkdir -p $(BUILD_DIR) $(CACHE_DIR) $(ENV_DIR)
 	cp -R $(APP_DIR)/. $(BUILD_DIR)
-	cd $(APP_DIR) && ../../bin/detect
+	# Run detect from the fixture app directory, but use the buildpack script from the repo root.
+	cd $(APP_DIR) && $(BUILDPACK_DIR)/bin/detect
 	$(BUILDPACK_DIR)/bin/compile $(BUILD_DIR) $(CACHE_DIR) $(ENV_DIR)
+	# Confirm staged dependencies are importable before checking the release metadata.
 	cd $(BUILD_DIR) && /bin/bash -lc 'source .profile.d/python.sh && $(PYTHON_BIN) -c "import fastapi; print(fastapi.__version__)"'
 	cd $(BUILD_DIR) && $(BUILDPACK_DIR)/bin/release
 
+# Run the single-app smoke test target against every app fixture under test/smoke.
+smoke-test:
+	@./scripts/smoke-test.sh
+
 # Start the staged sample app locally using the dependencies prepared by `test-buildpack`.
 start-local:
 	@cd $(BUILD_DIR) && /bin/bash -lc '\
 		source .profile.d/python.sh && \
+		# Prefer the app Procfile, otherwise reuse the buildpack release logic. \
 		if [ -f Procfile ]; then \
 			WEB_CMD=$$(awk -F": " '\''$$1 == "web" { print $$2; exit }'\'' Procfile); \
 		else \
@@ -35,5 +42,6 @@ start-local:
 			echo "Could not determine a web command to run locally."; \
 			exit 1; \
 		fi; \
+		# Local machines often expose `python3` instead of `python`, so normalize that here. \
 		WEB_CMD=$$(printf "%s" "$$WEB_CMD" | sed "s/^python /$(PYTHON_BIN) /"); \
 		eval "$$WEB_CMD"'

bin/release

@@ -10,6 +10,8 @@ else
 fi
 
 resolve_script_target() {
+  # Parse pyproject.toml with Python so we can safely read TOML instead of
+  # relying on brittle grep/awk parsing.
   "$PYTHON_BIN" -c '
 import sys
 try:
@@ -29,6 +31,8 @@ print(scripts.get(project_name) or scripts.get("start", ""))
 }
 
 build_python_entrypoint() {
+  # Convert a console-script target like `server.main:start` into a command
+  # that invokes the same callable directly with the resolved interpreter.
   local target="$1"
   local module_name="${target%%:*}"
   local function_name="${target##*:}"

scripts/smoke-test.sh

@@ -0,0 +1,33 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+ROOT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+# Allow CI or local runs to point at a different smoke-fixture directory.
+SMOKE_DIR="${SMOKE_DIR:-$ROOT_DIR/test/smoke}"
+
+if [ ! -d "$SMOKE_DIR" ]; then
+  echo "Smoke test directory not found: $SMOKE_DIR"
+  exit 1
+fi
+
+found_app=0
+
+# Run the single-app make target for every fixture app under test/smoke.
+for app_dir in "$SMOKE_DIR"/*; do
+  [ -d "$app_dir" ] || continue
+  found_app=1
+  echo "==> Smoke testing $(basename "$app_dir")"
+  if ! make -C "$ROOT_DIR" test-buildpack APP_DIR="${app_dir#$ROOT_DIR/}"; then
+    # Clean staged files before failing so the next run starts fresh.
+    make -C "$ROOT_DIR" clean-test-buildpack
+    exit 1
+  fi
+  # Clean after every app to keep smoke-test runs isolated from each other.
+  make -C "$ROOT_DIR" clean-test-buildpack
+done
+
+if [ "$found_app" -eq 0 ]; then
+  echo "No smoke test apps found in $SMOKE_DIR"
+  exit 1
+fi