Skip to content

Commit e204ea9

Browse files
committed
fix(test): correct test evaluation
- confirms Qt created a highlight before reset; - treats a destroyed highlightItem as the valid hidden state after reset; - no longer dereferences the stale highlight object. Assisted-by: Codex:GPT-5 Signed-off-by: Rello <github@scherello.de>
1 parent 5115458 commit e204ea9

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

test/qml/activitieswindow/tst_activitieswindow.qml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ Item {
6464
property ActivitiesWindow activitiesWindow
6565
property var activityList
6666
property var activityListView
67-
property var activityHighlight
6867
property var newActivitiesButtonLoader
6968

7069
function init()
@@ -134,8 +133,7 @@ Item {
134133
{
135134
activityListView.currentIndex = 0;
136135
tryVerify(() => activityListView.currentItem !== null);
137-
activityHighlight = activityListView.highlightItem;
138-
verify(activityHighlight);
136+
tryVerify(() => activityListView.highlightItem !== null);
139137

140138
activitiesWindow.requestActivate();
141139
activityListView.forceActiveFocus();
@@ -144,7 +142,7 @@ Item {
144142
activitiesWindow.resetActivityList();
145143

146144
compare(activityListView.currentItem, null);
147-
compare(activityHighlight.visible, false);
145+
tryVerify(() => activityListView.highlightItem === null || !activityListView.highlightItem.visible);
148146
}
149147

150148
function test_liveActivityDoesNotResetViewport()

0 commit comments

Comments
 (0)