Skip to content

[vault-exit] recheck rounding natspec #107

Description

@MathisGD

P2 Badge Account for idle-withdrawal rounding in the share bound

When idle assets are nonzero and the vault's asset/share ratio is non-integral, line 140 introduces a separate ERC-4626 withdrawal whose upward share rounding occurs in addition to the N market iterations. The stated exitAssets+N bound can therefore be one rounding unit short, causing a caller who uses the documented value to bound the permit allowance to revert; include the idle withdrawal in the bound and cover a non-1:1 share price in the new idle-assets tests.

AGENTS.md reference: AGENTS.md:L75-L77

Useful? React with 👍 / 👎.

Originally posted by @chatgpt-codex-connector[bot] in #104 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions