impr(profanity): change error message when disallowed word is detected in username (@Leonabcd123) (#7766)

!nuf

Author: Leonabcd123

backend/__tests__/api/controllers/user.spec.ts

@@ -193,7 +193,7 @@ describe("user controller test", () => {
         ],
       });
     });
-    it("should fail if username contains profanity", async () => {
+    it("should fail if username contains disallowed word", async () => {
       //GIVEN
       const newUser = {
         uid: uid,
@@ -212,7 +212,7 @@ describe("user controller test", () => {
       expect(body).toEqual({
         message: "Invalid request data schema",
         validationErrors: [
-          '"name" Profanity detected. Please remove it. If you believe this is a mistake, please contact us. (miodec)',
+          '"name" Disallowed word detected. Please remove it. If you believe this is a mistake, please contact us (miodec).',
         ],
       });
     });
@@ -277,7 +277,7 @@ describe("user controller test", () => {
       });
       expect(userIsNameAvailableMock).toHaveBeenCalledWith("bob", uid);
     });
-    it("returns 422 if username contains profanity", async () => {
+    it("returns 422 if username contains disallowed word", async () => {
       await mockApp
         .get("/users/checkName/newMiodec")
         //no authentication required
@@ -1139,7 +1139,7 @@ describe("user controller test", () => {
         validationErrors: ["Unrecognized key(s) in object: 'extra'"],
       });
     });
-    it("should fail if username contains profanity", async () => {
+    it("should fail if username contains disallowed word", async () => {
       //WHEN
       const { body } = await mockApp
         .patch("/users/name")
@@ -1151,7 +1151,7 @@ describe("user controller test", () => {
       expect(body).toEqual({
         message: "Invalid request data schema",
         validationErrors: [
-          '"name" Profanity detected. Please remove it. If you believe this is a mistake, please contact us. (miodec)',
+          '"name" Disallowed word detected. Please remove it. If you believe this is a mistake, please contact us (miodec).',
         ],
       });
     });
@@ -3310,7 +3310,7 @@ describe("user controller test", () => {
         expect.objectContaining({}),
       );
     });
-    it("should fail with profanity", async () => {
+    it("should fail with disallowed word", async () => {
       //WHEN
       const { body } = await mockApp
         .patch("/users/profile")
@@ -3330,11 +3330,11 @@ describe("user controller test", () => {
       expect(body).toEqual({
         message: "Invalid request data schema",
         validationErrors: [
-          '"bio" Profanity detected. Please remove it. If you believe this is a mistake, please contact us. (miodec)',
-          '"keyboard" Profanity detected. Please remove it. If you believe this is a mistake, please contact us. (miodec)',
-          '"socialProfiles.twitter" Profanity detected. Please remove it. If you believe this is a mistake, please contact us. (miodec)',
-          '"socialProfiles.github" Profanity detected. Please remove it. If you believe this is a mistake, please contact us. (miodec)',
-          '"socialProfiles.website" Profanity detected. Please remove it. If you believe this is a mistake, please contact us. (https://i-luv-miodec.com)',
+          '"bio" Disallowed word detected. Please remove it. If you believe this is a mistake, please contact us (miodec).',
+          '"keyboard" Disallowed word detected. Please remove it. If you believe this is a mistake, please contact us (miodec).',
+          '"socialProfiles.twitter" Disallowed word detected. Please remove it. If you believe this is a mistake, please contact us (miodec).',
+          '"socialProfiles.github" Disallowed word detected. Please remove it. If you believe this is a mistake, please contact us (miodec).',
+          '"socialProfiles.website" Disallowed word detected. Please remove it. If you believe this is a mistake, please contact us (https://i-luv-miodec.com).',
         ],
       });
     });

packages/contracts/__test__/validation/validation.spec.ts

@@ -1,8 +1,10 @@
 import { describe, it, expect } from "vitest";
 import * as Validation from "@monkeytype/schemas/validation/validation";
 
+const containsDisallowedWords = Validation.__testing.containsDisallowedWords;
+
 describe("validation", () => {
-  it("containsProfanity", () => {
+  it("containsDisallowedWords", () => {
     const testCases = [
       {
         text: "https://www.fuckyou.com",
@@ -35,7 +37,7 @@ describe("validation", () => {
     ];
 
     testCases.forEach((testCase) => {
-      expect(Validation.containsProfanity(testCase.text, "substring")).toBe(
+      expect(containsDisallowedWords(testCase.text, "substring")).toBe(
         testCase.expected,
       );
     });

packages/schemas/src/users.ts

@@ -12,7 +12,7 @@ import {
   PersonalBestSchema,
 } from "./shared";
 import { CustomThemeColorsSchema, FunboxNameSchema } from "./configs";
-import { doesNotContainProfanity } from "./validation/validation";
+import { doesNotContainDisallowedWords } from "./validation/validation";
 import { ConnectionSchema } from "./connections";
 
 const NoneFilterSchema = z.literal("none");
@@ -85,7 +85,7 @@ export type UserTag = z.infer<typeof UserTagSchema>;
 function profileDetailsBase(
   schema: ZodString,
 ): ZodEffects<ZodOptional<ZodEffects<ZodString>>> {
-  return doesNotContainProfanity("word", schema)
+  return doesNotContainDisallowedWords("word", schema)
     .optional()
     .transform((value) => (value === null ? undefined : value));
 }
@@ -242,7 +242,7 @@ export const FavoriteQuotesSchema = z.record(
 export type FavoriteQuotes = z.infer<typeof FavoriteQuotesSchema>;
 
 export const UserEmailSchema = z.string().email();
-export const UserNameSchema = doesNotContainProfanity(
+export const UserNameSchema = doesNotContainDisallowedWords(
   "substring",
   z
     .string()

packages/schemas/src/validation/validation.ts

@@ -2,7 +2,7 @@ import { replaceHomoglyphs } from "./homoglyphs";
 import { ZodEffects, ZodString } from "zod";
 
 // Sorry for the bad words
-const profanities = [
+const disallowedWords = [
   "miodec",
   "bitly",
   "niqqa",
@@ -403,7 +403,7 @@ function sanitizeString(str: string | undefined): string | undefined {
     .replace(/\s{3,}/g, "  ");
 }
 
-export function containsProfanity(
+function containsDisallowedWords(
   text: string,
   mode: "word" | "substring",
 ): boolean {
@@ -414,27 +414,29 @@ export function containsProfanity(
       return replaceHomoglyphs(sanitizeString(str) ?? "");
     });
 
-  const hasProfanity = profanities.some((profanity) => {
+  const hasDisallowedWords = disallowedWords.some((disallowedWord) => {
     return normalizedText.some((word) => {
       return mode === "word"
-        ? word.startsWith(profanity)
-        : word.includes(profanity);
+        ? word.startsWith(disallowedWord)
+        : word.includes(disallowedWord);
     });
   });
 
-  return hasProfanity;
+  return hasDisallowedWords;
 }
 
-export function doesNotContainProfanity(
+export function doesNotContainDisallowedWords(
   mode: "word" | "substring",
   schema: ZodString,
 ): ZodEffects<ZodString> {
   return schema.refine(
     (val) => {
-      return !containsProfanity(val, mode);
+      return !containsDisallowedWords(val, mode);
     },
     (val) => ({
-      message: `Profanity detected. Please remove it. If you believe this is a mistake, please contact us. (${val})`,
+      message: `Disallowed word detected. Please remove it. If you believe this is a mistake, please contact us (${val}).`,
     }),
   );
 }
+
+export const __testing = { containsDisallowedWords };