Improve drive power management and logging#2
Open
jgx0 wants to merge 8 commits into
Open
Conversation
Reduce drive-loop brownouts and disconnects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the
Pedrodrive subsystem and theOpModebase class, focusing on safer control scaling based on battery voltage and more robust loop timing. The main changes include adding voltage-aware power limiting to the drive logic, new configuration parameters for tuning, and a fix to prevent division by zero in the control loop timing.Drive power scaling and voltage handling:
Pedroto read the robot's voltage and automatically scale drive power if the voltage drops below a configurable threshold, enhancing safety and battery management. If voltage reading fails, the telemetry now reports it only once. (Pedro.kt)Pedro.kt)kotlin.math.minto support the new drive power scaling logic. (Pedro.kt)Loop timing robustness:
OpMode, added a minimum delta time constant and logic to ensure the control loop never divides by zero, preventing possible crashes or instability when measuring loop frequency. (OpMode.kt) [1] [2]State tracking:
voltageReadFailedflag toPedroto avoid redundant telemetry messages if voltage reading fails repeatedly. (Pedro.kt)Before issuing a pull request, please see the contributing page.