From 46c5a376cadc625d43ec7950cdfc38c5a1d5c6bd Mon Sep 17 00:00:00 2001 From: Satyam Pandey Date: Sat, 19 Sep 2026 17:14:20 +0530 Subject: [PATCH] fix(api): isolate package validation consumers from ambient type definitions --- api/package.json | 1 + api/scripts/test-package.cjs | 3 ++- api/test/tsconfig.legacy.json | 4 +++- api/test/tsconfig.modern.json | 4 +++- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/api/package.json b/api/package.json index ed2270714..84bb1e735 100644 --- a/api/package.json +++ b/api/package.json @@ -46,6 +46,7 @@ "compile:esm": "tsc -b ./tsconfig.esm.json && mve out/esm/main.js out/esm/main.mjs && node -e \"require('fs').writeFileSync('out/esm/package.json', '{\\\"type\\\":\\\"module\\\"}')\"", "compile:cjs": "tsc -b ./tsconfig.cjs.json && mve out/cjs/main.js out/cjs/main.cjs", "clean": "node -e \"const fs = require('fs'); fs.rmSync('./out', { recursive: true, force: true });\"", + "test": "npm run test:package", "test:package": "node ./scripts/test-package.cjs" }, "devDependencies": { diff --git a/api/scripts/test-package.cjs b/api/scripts/test-package.cjs index 7feb1180d..24f510963 100644 --- a/api/scripts/test-package.cjs +++ b/api/scripts/test-package.cjs @@ -55,7 +55,8 @@ try { testRoot, ); - const typescriptCli = path.join(packageRoot, 'node_modules', 'typescript', 'bin', 'tsc'); + const packageRequire = createRequire(path.join(packageRoot, 'package.json')); + const typescriptCli = packageRequire.resolve('typescript/bin/tsc'); const fixtureRoot = path.join(packageRoot, 'test'); for (const consumer of [ diff --git a/api/test/tsconfig.legacy.json b/api/test/tsconfig.legacy.json index cd09c6f5c..6089326f3 100644 --- a/api/test/tsconfig.legacy.json +++ b/api/test/tsconfig.legacy.json @@ -5,7 +5,9 @@ "moduleResolution": "Node", "noEmit": true, "strict": true, - "skipLibCheck": false + "skipLibCheck": false, + "types": ["node", "vscode"], + "typeRoots": ["../node_modules/@types"] }, "include": ["consumer.ts"] } diff --git a/api/test/tsconfig.modern.json b/api/test/tsconfig.modern.json index 1994e56c7..876a0dce6 100644 --- a/api/test/tsconfig.modern.json +++ b/api/test/tsconfig.modern.json @@ -5,7 +5,9 @@ "moduleResolution": "NodeNext", "noEmit": true, "strict": true, - "skipLibCheck": false + "skipLibCheck": false, + "types": ["node", "vscode"], + "typeRoots": ["../node_modules/@types"] }, "include": ["consumer.ts"] }