Hide "Mark as Viewed" checkboxes on files under commit nodes (#8418)

* Initial plan

* Hide mark as viewed checkboxes on files under commit nodes

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Fix compilation errors from optional checkboxState

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Address code review feedback - safer type checking

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Use sha comparison instead of parent tree traversal

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Revert proposed changes

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

Author: Copilot

src/view/treeNodes/directoryTreeNode.ts

@@ -124,7 +124,7 @@ export class DirectoryTreeNode extends TreeNode implements vscode.TreeItem {
 				if (!child.allChildrenViewed()) {
 					return false;
 				}
-			} else if (child.checkboxState.state !== vscode.TreeItemCheckboxState.Checked) {
+			} else if (!child.checkboxState || child.checkboxState.state !== vscode.TreeItemCheckboxState.Checked) {
 				return false;
 			}
 		}

src/view/treeNodes/fileChangeNode.ts

@@ -75,7 +75,7 @@ export class FileChangeNode extends TreeNode implements vscode.TreeItem {
 	public command: vscode.Command;
 	public opts: vscode.TextDocumentShowOptions;
 
-	public checkboxState: { state: vscode.TreeItemCheckboxState; tooltip?: string; accessibilityInformation: vscode.AccessibilityInformation };
+	public checkboxState?: { state: vscode.TreeItemCheckboxState; tooltip?: string; accessibilityInformation: vscode.AccessibilityInformation };
 
 	get status(): GitChangeType {
 		return this.changeModel.status;
@@ -155,13 +155,28 @@ export class FileChangeNode extends TreeNode implements vscode.TreeItem {
 		}
 	}
 
+	/**
+	 * Check if this file node is under a commit node in the tree hierarchy.
+	 * Files under commit nodes should not have checkboxes.
+	 */
+	private isUnderCommitNode(): boolean {
+		// If the file's sha is different from the PR's head sha, it's from an older commit
+		// and should not have a checkbox
+		return this.changeModel.sha !== undefined && this.changeModel.sha !== this.pullRequest.head?.sha;
+	}
+
 	updateViewed(viewed: ViewedState) {
 		this.changeModel.updateViewed(viewed);
 		this.contextValue = `${Schemes.FileChange}:${GitChangeType[this.changeModel.status]}:${viewed === ViewedState.VIEWED ? 'viewed' : 'unviewed'
 			}`;
-		this.checkboxState = viewed === ViewedState.VIEWED ?
-			{ state: vscode.TreeItemCheckboxState.Checked, tooltip: vscode.l10n.t('Mark File as Unviewed'), accessibilityInformation: { label: vscode.l10n.t('Mark file {0} as unviewed', this.label ?? '') } } :
-			{ state: vscode.TreeItemCheckboxState.Unchecked, tooltip: vscode.l10n.t('Mark File as Viewed'), accessibilityInformation: { label: vscode.l10n.t('Mark file {0} as viewed', this.label ?? '') } };
+		// Don't show checkboxes for files under commit nodes
+		if (!this.isUnderCommitNode()) {
+			this.checkboxState = viewed === ViewedState.VIEWED ?
+				{ state: vscode.TreeItemCheckboxState.Checked, tooltip: vscode.l10n.t('Mark File as Unviewed'), accessibilityInformation: { label: vscode.l10n.t('Mark file {0} as unviewed', this.label ?? '') } } :
+				{ state: vscode.TreeItemCheckboxState.Unchecked, tooltip: vscode.l10n.t('Mark File as Viewed'), accessibilityInformation: { label: vscode.l10n.t('Mark file {0} as viewed', this.label ?? '') } };
+		} else {
+			this.checkboxState = undefined;
+		}
 		this.pullRequestManager.setFileViewedContext();
 	}
 

src/view/treeNodes/treeUtils.ts

@@ -35,9 +35,10 @@ export namespace TreeUtils {
 					continue;
 				}
 				if (!checkedNodes.includes(selected) && !uncheckedNodes.includes(selected)) {
-					if (selected.checkboxState.state === vscode.TreeItemCheckboxState.Unchecked) {
+					// Only process files that have checkboxes (files without checkboxState, like those under commits, are skipped)
+					if (selected.checkboxState?.state === vscode.TreeItemCheckboxState.Unchecked) {
 						checkedNodes.push(selected);
-					} else {
+					} else if (selected.checkboxState?.state === vscode.TreeItemCheckboxState.Checked) {
 						uncheckedNodes.push(selected);
 					}
 				}