Try to protect against mysteriously undefined values in update time check (#8509)

* Try to protect against mysteriously undefined values in update time check

* Copilot PR feedback

Author: alexr00

src/github/graphql.ts

@@ -294,28 +294,28 @@ export interface LatestCommit {
 
 export interface LatestReviewThread {
 	comments: {
-		nodes: {
+		nodes: ({
 			createdAt: string;
-		}[];
+		} | null)[];
 	}
 }
 
 export interface LatestUpdatesResponse {
 	repository: {
 		pullRequest: {
 			reactions: {
-				nodes: {
+				nodes: ({
 					createdAt: string;
-				}[];
+				} | null)[];
 			}
 			updatedAt: string;
 			comments: {
 				nodes: {
 					updatedAt: string;
 					reactions: {
-						nodes: {
+						nodes: ({
 							createdAt: string;
-						}[];
+						} | null)[];
 					}
 				}[];
 			}

src/github/issueModel.ts

@@ -446,24 +446,25 @@ export class IssueModel<TItem extends Issue = Issue> extends Disposable {
 			const times = [
 				time,
 				new Date(data.repository.pullRequest.updatedAt),
-				...(data.repository.pullRequest.reactions.nodes.map(node => new Date(node.createdAt))),
+				...(data.repository.pullRequest.reactions.nodes.filter((node): node is { createdAt: string } => !!node).map(node => new Date(node.createdAt))),
 				...(data.repository.pullRequest.comments.nodes.map(node => new Date(node.updatedAt))),
-				...(data.repository.pullRequest.comments.nodes.flatMap(node => node.reactions.nodes.map(reaction => new Date(reaction.createdAt)))),
+				...(data.repository.pullRequest.comments.nodes.flatMap(node => node.reactions.nodes.filter((reaction): reaction is { createdAt: string } => !!reaction).map(reaction => new Date(reaction.createdAt)))),
 				...(data.repository.pullRequest.timelineItems.nodes.map(node => {
 					const latestCommit = node as (Partial<LatestCommit> | null);
 					if (latestCommit?.commit?.committedDate) {
 						return new Date(latestCommit.commit.committedDate);
 					}
 					const latestReviewThread = node as (Partial<LatestReviewThread> | null);
-					if ((latestReviewThread?.comments?.nodes.length ?? 0) > 0) {
+					if (((latestReviewThread?.comments?.nodes.length ?? 0) > 0) && latestReviewThread!.comments!.nodes[0]) {
 						return new Date(latestReviewThread!.comments!.nodes[0].createdAt);
+					} else if (node) {
+						return new Date((node as { createdAt: string }).createdAt);
 					}
-					return new Date((node as { createdAt: string }).createdAt);
 				}))
 			];
 
 			// Sort times and return the most recent one
-			return new Date(Math.max(...times.map(t => t.getTime())));
+			return new Date(Math.max(...times.filter((t): t is Date => !!t).map(t => t.getTime())));
 		} catch (e) {
 			Logger.error(`Error fetching timeline events of issue #${this.number} - ${formatError(e)}`, IssueModel.ID);
 			return time; // Return the original time in case of an error