Clean up now that we support multi webview (#8503)

Author: alexr00

src/github/issueOverview.ts

@@ -220,7 +220,7 @@ export class IssueOverviewPanel<TItem extends IssueModel = IssueModel> extends W
 
 	public async refreshPanel(): Promise<void> {
 		if (this._panel && this._panel.visible) {
-			await this.update(this._folderRepositoryManager, this._item);
+			await this.updateItem(this._item);
 		}
 	}
 
@@ -340,19 +340,14 @@ export class IssueOverviewPanel<TItem extends IssueModel = IssueModel> extends W
 	 */
 	public async updateWithIdentity(foldersManager: FolderRepositoryManager, identity: UnresolvedIdentity, issueModel?: TItem, progressLocation?: string): Promise<void> {
 		this._identity = identity;
-
-		if (this._folderRepositoryManager !== foldersManager) {
-			this._folderRepositoryManager = foldersManager;
-			this.registerPrListeners();
-		}
+		this._folderRepositoryManager = foldersManager;
 
 		this._postMessage({
 			command: 'set-scroll',
 			scrollPosition: this._scrollPosition,
 		});
 
-		const isNewItem = !this._item || (this._item.number !== identity.number);
-		if (isNewItem || !this._panel.webview.html) {
+		if (!this._panel.webview.html) {
 			this._panel.webview.html = this.getHtmlForWebview();
 			if (this._item) {
 				this._postMessage({ command: 'pr.clear' });
@@ -377,15 +372,6 @@ export class IssueOverviewPanel<TItem extends IssueModel = IssueModel> extends W
 		}
 	}
 
-	public async update(foldersManager: FolderRepositoryManager, issueModel: TItem, progressLocation?: string): Promise<void> {
-		const identity: UnresolvedIdentity = {
-			owner: issueModel.remote.owner,
-			repo: issueModel.remote.repositoryName,
-			number: issueModel.number
-		};
-		return this.updateWithIdentity(foldersManager, identity, issueModel, progressLocation);
-	}
-
 	protected override async _onDidReceiveMessage(message: IRequestMessage<any>) {
 		const result = await super._onDidReceiveMessage(message);
 		if (result !== this.MESSAGE_UNHANDLED) {

src/github/pullRequestOverview.ts

@@ -120,7 +120,6 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
 		this._postMessage({ command: 'pr.scrollToPendingReview' });
 	}
 
-
 	/**
 	 * Get the currently active pull request from the active panel
 	 */
@@ -297,16 +296,11 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
 	}
 
 	protected override async updateItem(pullRequestModel: PullRequestModel): Promise<void> {
-		const isSamePullRequest = pullRequestModel.equals(this._item);
-		if (this._updatingPromise && isSamePullRequest) {
+		if (this._updatingPromise) {
 			Logger.error('Already updating pull request webview', PullRequestOverviewPanel.ID);
 			return;
-		} else if (this._updatingPromise && !isSamePullRequest) {
-			this._item = pullRequestModel;
-			await this._updatingPromise;
-		} else {
-			this._item = pullRequestModel;
 		}
+		this._item = pullRequestModel;
 
 		try {
 			const updatingPromise = Promise.all([
@@ -365,11 +359,6 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
 				);
 			}
 
-			if (!this._item.equals(pullRequestModel)) {
-				// Updated PR is no longer the current one
-				return;
-			}
-
 			this._item = pullRequest;
 			this.registerPrListeners();
 			this._repositoryDefaultBranch = defaultBranch!;
@@ -472,18 +461,6 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
 		PullRequestOverviewPanel._onVisible.fire(this._item);
 	}
 
-	public override async update(
-		folderRepositoryManager: FolderRepositoryManager,
-		pullRequestModel: PullRequestModel,
-	): Promise<void> {
-		const identity: UnresolvedIdentity = {
-			owner: pullRequestModel.remote.owner,
-			repo: pullRequestModel.remote.repositoryName,
-			number: pullRequestModel.number
-		};
-		return this.updateWithIdentity(folderRepositoryManager, identity, pullRequestModel, 'pr:github');
-	}
-
 	protected override async _onDidReceiveMessage(message: IRequestMessage<any>) {
 		const result = await super._onDidReceiveMessage(message);
 		if (result !== this.MESSAGE_UNHANDLED) {