Address code review feedback: remove unused parameter and rename function

Co-authored-by: joshspicer <23246594+joshspicer@users.noreply.github.com>

Author: Copilot

src/@types/vscode.proposed.chatParticipantAdditions.d.ts

@@ -103,6 +103,7 @@ declare module 'vscode' {
 		isConfirmed?: boolean;
 		isComplete?: boolean;
 		toolSpecificData?: ChatTerminalToolInvocationData;
+		fromSubAgent?: boolean;
 
 		constructor(toolName: string, toolCallId: string, isError?: boolean);
 	}
@@ -646,7 +647,13 @@ declare module 'vscode' {
 	}
 
 	export interface ChatRequest {
-		modeInstructions?: string;
-		modeInstructionsToolReferences?: readonly ChatLanguageModelToolReference[];
+		readonly modeInstructions?: string;
+		readonly modeInstructions2?: ChatRequestModeInstructions;
+	}
+
+	export interface ChatRequestModeInstructions {
+		readonly content: string;
+		readonly toolReferences?: readonly ChatLanguageModelToolReference[];
+		readonly metadata?: Record<string, boolean | string | number>;
 	}
 }

src/@types/vscode.proposed.chatParticipantPrivate.d.ts

@@ -187,6 +187,8 @@ declare module 'vscode' {
 
 		isQuotaExceeded?: boolean;
 
+		isRateLimited?: boolean;
+
 		level?: ChatErrorLevel;
 
 		code?: string;
@@ -219,6 +221,10 @@ declare module 'vscode' {
 		chatSessionId?: string;
 		chatInteractionId?: string;
 		terminalCommand?: string;
+		/**
+		 * Lets us add some nicer UI to toolcalls that came from a sub-agent, but in the long run, this should probably just be rendered in a similar way to thinking text + tool call groups
+		 */
+		fromSubAgent?: boolean;
 	}
 
 	export interface LanguageModelToolInvocationPrepareOptions<T> {
@@ -233,12 +239,13 @@ declare module 'vscode' {
 
 	export interface PreparedToolInvocation {
 		pastTenseMessage?: string | MarkdownString;
-		presentation?: 'hidden' | undefined;
+		presentation?: 'hidden' | 'hiddenAfterComplete' | undefined;
 	}
 
 	export class ExtendedLanguageModelToolResult extends LanguageModelToolResult {
 		toolResultMessage?: string | MarkdownString;
 		toolResultDetails?: Array<Uri | Location>;
+		toolMetadata?: unknown;
 	}
 
 	// #region Chat participant detection

src/github/copilotRemoteAgent.ts

@@ -350,7 +350,7 @@ export class CopilotRemoteAgentManager extends Disposable {
 	}
 
 	async isAssignable(): Promise<boolean> {
-		const cacheAndReturn = (b: boolean) => {
+		const setCachedResult = (b: boolean) => {
 			this._isAssignable = b;
 			return b;
 		};
@@ -361,7 +361,7 @@ export class CopilotRemoteAgentManager extends Disposable {
 
 		const repoInfo = await this.repoInfo();
 		if (!repoInfo) {
-			return cacheAndReturn(false);
+			return setCachedResult(false);
 		}
 
 		const { fm } = repoInfo;
@@ -372,12 +372,12 @@ export class CopilotRemoteAgentManager extends Disposable {
 			const allAssignableUsers = fm.getAllAssignableUsers();
 
 			if (!allAssignableUsers) {
-				return cacheAndReturn(false);
+				return setCachedResult(false);
 			}
-			return cacheAndReturn(allAssignableUsers.some(user => COPILOT_LOGINS.includes(user.login)));
+			return setCachedResult(allAssignableUsers.some(user => COPILOT_LOGINS.includes(user.login)));
 		} catch (error) {
 			// If there's an error fetching assignable users, assume not assignable
-			return cacheAndReturn(false);
+			return setCachedResult(false);
 		}
 	}
 

src/issues/issueTodoProvider.ts

@@ -30,7 +30,7 @@ export class IssueTodoProvider implements vscode.CodeActionProvider, vscode.Code
 		this.expression = triggers.length > 0 ? new RegExp(triggers.map(trigger => escapeRegExp(trigger)).join('|')) : undefined;
 	}
 
-	private findTodoInLine(lineNumber: number, line: string): { match: RegExpMatchArray; search: number; insertIndex: number } | undefined {
+	private findTodoInLine(line: string): { match: RegExpMatchArray; search: number; insertIndex: number } | undefined {
 		const truncatedLine = line.substring(0, MAX_LINE_LENGTH);
 		const matches = truncatedLine.match(ISSUE_OR_URL_EXPRESSION);
 		if (matches) {
@@ -61,7 +61,7 @@ export class IssueTodoProvider implements vscode.CodeActionProvider, vscode.Code
 		let lineNumber = range.start.line;
 		do {
 			const line = document.lineAt(lineNumber).text;
-			const todoInfo = this.findTodoInLine(lineNumber, line);
+			const todoInfo = this.findTodoInLine(line);
 			if (todoInfo) {
 				const { match, search, insertIndex } = todoInfo;
 				// Create GitHub Issue action
@@ -115,7 +115,7 @@ export class IssueTodoProvider implements vscode.CodeActionProvider, vscode.Code
 		const codeLenses: vscode.CodeLens[] = [];
 		for (let lineNumber = 0; lineNumber < document.lineCount; lineNumber++) {
 			const line = document.lineAt(lineNumber).text;
-			const todoInfo = this.findTodoInLine(lineNumber, line);
+			const todoInfo = this.findTodoInLine(line);
 			if (todoInfo) {
 				const { match, search, insertIndex } = todoInfo;
 				const range = new vscode.Range(lineNumber, search, lineNumber, search + match[0].length);