Show empty commits with centered webview instead of notification (#8103)

Copilot · alexr00 · web-flow · commit 7bc0db6d6612 · 2025-11-06T11:32:48.000Z
* Initial plan

* Initial planning for empty commit display feature

Co-authored-by: alexr00 &lt;38270282+alexr00@users.noreply.github.com&gt;

* Add EmptyCommitFileSystemProvider for displaying empty commits

Co-authored-by: alexr00 &lt;38270282+alexr00@users.noreply.github.com&gt;

* Replace file system provider with webview for empty commits

- Removed EmptyCommitFileSystemProvider and related URI scheme
- Created showEmptyCommitWebview() function with centered message
- Updated openCommitChanges() to accept extensionUri and show webview
- Styled webview to display message centered similar to GitHub.com

Co-authored-by: alexr00 &lt;38270282+alexr00@users.noreply.github.com&gt;

* Update empty commit webview styling to match design

- Added SVG document icon above the message
- Split message into title and subtitle with different styling
- Title: "No changes to show." in regular foreground color
- Subtitle: "This commit has no content." in muted description color
- Adjusted spacing and font sizes to match GitHub.com design

Co-authored-by: alexr00 &lt;38270282+alexr00@users.noreply.github.com&gt;

* 💄

* clean up

* Add icon path to empty commit webview panel

- Set git-commit icon for the webview panel tab
- Icon appears in both light and dark themes
- Uses codicons/git-commit.svg from resources

Co-authored-by: alexr00 &lt;38270282+alexr00@users.noreply.github.com&gt;

* more clean up

---------

Co-authored-by: copilot-swe-agent[bot] &lt;198982749+Copilot@users.noreply.github.com&gt;
Co-authored-by: alexr00 &lt;38270282+alexr00@users.noreply.github.com&gt;
diff --git a/src/@types/vscode.proposed.chatParticipantAdditions.d.ts b/src/@types/vscode.proposed.chatParticipantAdditions.d.ts
@@ -167,7 +167,14 @@ declare module 'vscode' {
 		constructor(value: ChatResponseDiffEntry[], title: string, readOnly?: boolean);
 	}
 
-	export type ExtendedChatResponsePart = ChatResponsePart | ChatResponseTextEditPart | ChatResponseNotebookEditPart | ChatResponseConfirmationPart | ChatResponseCodeCitationPart | ChatResponseReferencePart2 | ChatResponseMovePart | ChatResponseExtensionsPart | ChatResponsePullRequestPart | ChatPrepareToolInvocationPart | ChatToolInvocationPart | ChatResponseMultiDiffPart | ChatResponseThinkingProgressPart;
+	export class ChatResponseExternalEditPart {
+		uris: Uri[];
+		callback: () => Thenable<unknown>;
+		applied: Thenable<void>;
+		constructor(uris: Uri[], callback: () => Thenable<unknown>);
+	}
+
+	export type ExtendedChatResponsePart = ChatResponsePart | ChatResponseTextEditPart | ChatResponseNotebookEditPart | ChatResponseConfirmationPart | ChatResponseCodeCitationPart | ChatResponseReferencePart2 | ChatResponseMovePart | ChatResponseExtensionsPart | ChatResponsePullRequestPart | ChatPrepareToolInvocationPart | ChatToolInvocationPart | ChatResponseMultiDiffPart | ChatResponseThinkingProgressPart | ChatResponseExternalEditPart;
 	export class ChatResponseWarningPart {
 		value: MarkdownString;
 		constructor(value: string | MarkdownString);
@@ -301,6 +308,14 @@ declare module 'vscode' {
 
 		notebookEdit(target: Uri, isDone: true): void;
 
+		/**
+		 * Makes an external edit to one or more resources. Changes to the
+		 * resources made within the `callback` and before it resolves will be
+		 * tracked as agent edits. This can be used to track edits made from
+		 * external tools that don't generate simple {@link textEdit textEdits}.
+		 */
+		externalEdit<T>(target: Uri | Uri[], callback: () => Thenable<T>): Thenable<T>;
+
 		markdownWithVulnerabilities(value: string | MarkdownString, vulnerabilities: ChatVulnerability[]): void;
 		codeblockUri(uri: Uri, isEdit?: boolean): void;
 		push(part: ChatResponsePart | ChatResponseTextEditPart | ChatResponseWarningPart | ChatResponseProgressPart2): void;
diff --git a/src/@types/vscode.proposed.chatParticipantPrivate.d.ts b/src/@types/vscode.proposed.chatParticipantPrivate.d.ts
@@ -87,6 +87,8 @@ declare module 'vscode' {
 		 * Events for edited files in this session collected since the last request.
 		 */
 		readonly editedFileEvents?: ChatRequestEditedFileEvent[];
+
+		readonly isSubagent?: boolean;
 	}
 
 	export enum ChatRequestEditedFileEventKind {
diff --git a/src/github/emptyCommitWebview.ts b/src/github/emptyCommitWebview.ts
@@ -0,0 +1,83 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import * as vscode from 'vscode';
+
+/**
+ * Opens a webview panel to display a message for an empty commit.
+ * The message is centered and styled similar to GitHub.com.
+ */
+export function showEmptyCommitWebview(extensionUri: vscode.Uri, commitSha: string): void {
+	const panel = vscode.window.createWebviewPanel(
+		'emptyCommit',
+		vscode.l10n.t('Commit {0}', commitSha.substring(0, 7)),
+		vscode.ViewColumn.Active,
+		{
+			enableScripts: false,
+			localResourceRoots: []
+		}
+	);
+
+	panel.iconPath = {
+		light: vscode.Uri.joinPath(extensionUri, 'resources', 'icons', 'codicons', 'git-commit.svg'),
+		dark: vscode.Uri.joinPath(extensionUri, 'resources', 'icons', 'codicons', 'git-commit.svg')
+	};
+
+	panel.webview.html = getEmptyCommitHtml();
+}
+
+function getEmptyCommitHtml(): string {
+	return `<!DOCTYPE html>
+<html lang="en">
+<head>
+	<meta charset="UTF-8">
+	<meta name="viewport" content="width=device-width, initial-scale=1.0">
+	<title>Empty Commit</title>
+	<style>
+		body {
+			margin: 0;
+			padding: 0;
+			height: 100vh;
+			display: flex;
+			align-items: center;
+			justify-content: center;
+		}
+		.container {
+			text-align: center;
+			padding: 2rem;
+			max-width: 600px;
+		}
+		.icon {
+			margin-bottom: 1.5rem;
+			opacity: 0.6;
+		}
+		.icon svg {
+			width: 64px;
+			height: 64px;
+			fill: currentColor;
+		}
+		.title {
+			font-size: 1.25rem;
+			font-weight: 400;
+			margin-bottom: 0.5rem;
+			color: var(--vscode-foreground);
+		}
+		.subtitle {
+			font-size: 0.95rem;
+			color: var(--vscode-descriptionForeground);
+		}
+	</style>
+</head>
+<body>
+	<div class="container">
+		<div class="icon">
+			<svg width="16" height="16" viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg" fill="currentColor"><path d="M9.99994 11.999H4.99994V10.999H9.99994V11.999Z"/><path d="M7.99994 5.99902H9.99994V6.99902H7.99994V9H6.99994V6.99902H4.99994V5.99902H6.99994V4H7.99994V5.99902Z"/><path fill-rule="evenodd" clip-rule="evenodd" d="M10.7099 1.28906L13.7099 4.28906L13.9999 4.99902V13.999L12.9999 14.999H2.99994L1.99994 13.999V1.99902L2.99994 0.999023H9.99994L10.7099 1.28906ZM2.99994 13.999H12.9999V4.99902L9.99994 1.99902H2.99994V13.999Z"/></svg>
+		</div>
+		<div class="title">No changes to show.</div>
+		<div class="subtitle">This commit has no content.</div>
+	</div>
+</body>
+</html>`;
+}
diff --git a/src/github/pullRequestModel.ts b/src/github/pullRequestModel.ts
@@ -11,6 +11,7 @@ import * as vscode from 'vscode';
 import { OctokitCommon } from './common';
 import { ConflictResolutionModel } from './conflictResolutionModel';
 import { CredentialStore } from './credentials';
+import { showEmptyCommitWebview } from './emptyCommitWebview';
 import { FolderRepositoryManager } from './folderRepositoryManager';
 import { GitHubRepository, GraphQLError, GraphQLErrorType } from './githubRepository';
 import {
@@ -1465,7 +1466,7 @@ export class PullRequestModel extends IssueModel<PullRequest> implements IPullRe
 		return vscode.commands.executeCommand('vscode.changes', vscode.l10n.t('Changes in Pull Request #{0}', pullRequestModel.number), args);
 	}
 
-	static async openCommitChanges(githubRepository: GitHubRepository, commitSha: string) {
+	static async openCommitChanges(extensionUri: vscode.Uri, githubRepository: GitHubRepository, commitSha: string) {
 		try {
 			const parentCommit = await githubRepository.getCommitParent(commitSha);
 			if (!parentCommit) {
@@ -1475,7 +1476,8 @@ export class PullRequestModel extends IssueModel<PullRequest> implements IPullRe
 
 			const changes = await githubRepository.compareCommits(parentCommit, commitSha);
 			if (!changes?.files || changes.files.length === 0) {
-				vscode.window.showInformationMessage(vscode.l10n.t('No changes found in commit {0}', commitSha.substring(0, 7)));
+				// Show a webview with the empty commit message instead of a notification
+				showEmptyCommitWebview(extensionUri, commitSha);
 				return;
 			}
 
diff --git a/src/github/pullRequestOverview.ts b/src/github/pullRequestOverview.ts
@@ -554,7 +554,7 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
 	private async openCommitChanges(message: IRequestMessage<OpenCommitChangesArgs>): Promise<void> {
 		try {
 			const { commitSha } = message.args;
-			await PullRequestModel.openCommitChanges(this._item.githubRepository, commitSha);
+			await PullRequestModel.openCommitChanges(this._extensionUri, this._item.githubRepository, commitSha);
 			this._replyMessage(message, {});
 		} catch (error) {
 			Logger.error(`Failed to open commit changes: ${formatError(error)}`, PullRequestOverviewPanel.ID);

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,8 @@ declare module 'vscode' {`
`87`	`87`	`* Events for edited files in this session collected since the last request.`
`88`	`88`	`*/`
`89`	`89`	`readonly editedFileEvents?: ChatRequestEditedFileEvent[];`
	`90`	`+`
	`91`	`+ readonly isSubagent?: boolean;`
`90`	`92`	`}`
`91`	`93`
`92`	`94`	`export enum ChatRequestEditedFileEventKind {`