Remove external uses of current panel

Part of #3058

Author: alexr00

src/commands.ts

@@ -1065,16 +1065,18 @@ export function registerCommands(
 
 	context.subscriptions.push(
 		vscode.commands.registerCommand('pr.refreshDescription', async () => {
-			if (PullRequestOverviewPanel.currentPanel) {
-				PullRequestOverviewPanel.refresh();
+			const panel = PullRequestOverviewPanel.getActivePanel();
+			if (panel) {
+				panel.refreshPanel();
 			}
 		}),
 	);
 
 	context.subscriptions.push(vscode.commands.registerCommand('pr.focusDescriptionInput',
 		async () => {
-			if (PullRequestOverviewPanel.currentPanel) {
-				PullRequestOverviewPanel.scrollToReview();
+			const panel = PullRequestOverviewPanel.getActivePanel();
+			if (panel) {
+				panel.scrollToPendingReview();
 			}
 		}
 	));

src/github/issueOverview.ts

@@ -82,6 +82,19 @@ export class IssueOverviewPanel<TItem extends IssueModel = IssueModel> extends W
 		}
 	}
 
+	/**
+	 * Return the panel whose webview is currently active (focused),
+	 * or `undefined` when no issue/PR panel is active.
+	 * Today there is at most one panel; with multiple panels this
+	 * will iterate the panel map.
+	 */
+	public static getActivePanel(): IssueOverviewPanel | undefined {
+		if (this.currentPanel?._panel.active) {
+			return this.currentPanel;
+		}
+		return undefined;
+	}
+
 	protected setPanelTitle(title: string): void {
 		try {
 			this._panel.title = title;

src/github/pullRequestOverview.ts

@@ -109,24 +109,46 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
 	}
 
 	public static override refresh(): void {
-		if (this.currentPanel) {
-			this.currentPanel.refreshPanel();
+		const panel = this.getActivePanel();
+		if (panel) {
+			panel.refreshPanel();
 		}
 	}
 
-	public static scrollToReview(): void {
-		if (this.currentPanel) {
-			this.currentPanel._postMessage({ command: 'pr.scrollToPendingReview' });
+	public static scrollToReview(owner: string, repo: string, number: number): void {
+		const panel = this.findPanel(owner, repo, number);
+		if (panel) {
+			panel.scrollToPendingReview();
 		}
 	}
 
+	/**
+	 * Scroll the webview to the pending review section.
+	 */
+	public scrollToPendingReview(): void {
+		this._postMessage({ command: 'pr.scrollToPendingReview' });
+	}
+
 	/**
 	 * Get the currently active pull request from the current panel
 	 */
 	public static getCurrentPullRequest(): PullRequestModel | undefined {
 		return this.currentPanel?._item;
 	}
 
+	/**
+	 * Return the panel whose webview is currently active (focused),
+	 * or `undefined` when no PR panel is active.
+	 * Today there is at most one panel; with multiple panels this
+	 * will iterate the panel map.
+	 */
+	public static override getActivePanel(): PullRequestOverviewPanel | undefined {
+		if (this.currentPanel?._panel.active) {
+			return this.currentPanel;
+		}
+		return undefined;
+	}
+
 	/**
 	 * Find the panel showing a specific pull request.
 	 * Currently there is at most one panel, but this will support

src/lm/issueContextProvider.ts

@@ -29,7 +29,7 @@ export class IssueContextProvider implements vscode.ChatContextProvider {
 	) { }
 
 	async provideChatContextForResource(_options: { resource: vscode.Uri }, _token: vscode.CancellationToken): Promise<IssueChatContextItem | undefined> {
-		const item = IssueOverviewPanel.currentPanel?.getCurrentItem();
+		const item = IssueOverviewPanel.getActivePanel()?.getCurrentItem();
 		if (item) {
 			return this._issueToUnresolvedContext(item);
 		}

src/lm/pullRequestContextProvider.ts

@@ -92,7 +92,7 @@ Active pull request (may not be the same as open pull request): ${folderManager.
 	}
 
 	async provideChatContextForResource(_options: { resource: vscode.Uri }, _token: vscode.CancellationToken): Promise<PRChatContextItem | undefined> {
-		const item = PullRequestOverviewPanel.currentPanel?.getCurrentItem();
+		const item = PullRequestOverviewPanel.getActivePanel()?.getCurrentItem();
 		if (item) {
 			return this._prToUnresolvedContext(item);
 		}

src/lm/tools/openPullRequestTool.ts

@@ -13,8 +13,8 @@ export class OpenPullRequestTool extends PullRequestTool {
 	public static readonly toolId = 'github-pull-request_openPullRequest';
 
 	protected _findActivePullRequest(): PullRequestModel | undefined {
-		// First check if there's a PR overview panel open
-		const panelPR = PullRequestOverviewPanel.currentPanel?.getCurrentItem();
+		// First check if there's an active PR overview panel
+		const panelPR = PullRequestOverviewPanel.getActivePanel()?.getCurrentItem();
 		if (panelPR) {
 			return panelPR;
 		}

src/view/pullRequestCommentController.ts

@@ -497,7 +497,7 @@ export class PullRequestCommentController extends CommentControllerBase implemen
 			number: this.pullRequestModel.number
 		};
 		await PullRequestOverviewPanel.createOrShow(this._telemetry, this._folderRepoManager.context.extensionUri, this._folderRepoManager, identity, this.pullRequestModel);
-		PullRequestOverviewPanel.scrollToReview();
+		PullRequestOverviewPanel.scrollToReview(identity.owner, identity.repo, identity.number);
 
 		/* __GDPR__
 			"pr.openDescription" : {}

src/view/reviewCommentController.ts

@@ -723,7 +723,10 @@ export class ReviewCommentController extends CommentControllerBase implements Co
 
 	public async openReview(): Promise<void> {
 		await this._reviewManager.openDescription();
-		PullRequestOverviewPanel.scrollToReview();
+		const pr = this._folderRepoManager.activePullRequest;
+		if (pr) {
+			PullRequestOverviewPanel.scrollToReview(pr.remote.owner, pr.remote.repositoryName, pr.number);
+		}
 	}
 
 	// #endregion