Skip to content

Commit 66ca67b

Browse files
committed
Also adopt in focus view
1 parent ed6205e commit 66ca67b

5 files changed

Lines changed: 34 additions & 18 deletions

File tree

package.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2064,6 +2064,10 @@
20642064
"command": "pr.readyForReview",
20652065
"when": "gitHubOpenRepositoryCount != 0 && github:inReviewMode"
20662066
},
2067+
{
2068+
"command": "pr.readyForReviewAndMerge",
2069+
"when": "false"
2070+
},
20672071
{
20682072
"command": "pr.openPullRequestOnGitHub",
20692073
"when": "gitHubOpenRepositoryCount != 0 && github:inReviewMode"
@@ -3534,11 +3538,11 @@
35343538
},
35353539
{
35363540
"command": "pr.readyForReview",
3537-
"when": "webviewId == PullRequestOverview && github:readyForReviewMenu"
3541+
"when": "(webviewId == PullRequestOverview || webviewId == 'github:activePullRequest') && github:readyForReviewMenu"
35383542
},
35393543
{
35403544
"command": "pr.readyForReviewAndMerge",
3541-
"when": "webviewId == PullRequestOverview && github:readyForReviewMenu && github:readyForReviewMenuWithMerge"
3545+
"when": "(webviewId == PullRequestOverview || webviewId == 'github:activePullRequest') && github:readyForReviewMenu && github:readyForReviewMenuWithMerge"
35423546
},
35433547
{
35443548
"command": "pr.openChanges",

package.nls.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,8 @@
193193
"command.pr.dismissNotification.title": "Dismiss Notification",
194194
"command.pr.markAllCopilotNotificationsAsRead.title": "Dismiss All Copilot Notifications",
195195
"command.pr.merge.title": "Merge Pull Request",
196-
"command.pr.readyForReview.title": "Mark Pull Request Ready For Review",
197-
"command.pr.readyForReviewAndMerge.title": "Mark Pull Request Ready, Approve, and Auto-Merge",
196+
"command.pr.readyForReview.title": "Ready for Review",
197+
"command.pr.readyForReviewAndMerge.title": "Ready, Approve, and Auto-Merge",
198198
"command.pr.openPullRequestOnGitHub.title": "Open Pull Request on GitHub",
199199
"command.pr.openAllDiffs.title": "Open All Diffs",
200200
"command.pr.refreshPullRequest.title": "Refresh Pull Request",

src/github/activityBarViewProvider.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import * as vscode from 'vscode';
77
import { openPullRequestOnGitHub } from '../commands';
88
import { FolderRepositoryManager } from './folderRepositoryManager';
99
import { GithubItemStateEnum, IAccount, isITeam, ITeam, PullRequestMergeability, reviewerId, ReviewEventEnum, ReviewState } from './interface';
10-
import { PullRequestModel } from './pullRequestModel';
10+
import { isCopilotOnMyBehalf, PullRequestModel } from './pullRequestModel';
1111
import { getDefaultMergeMethod } from './pullRequestOverview';
1212
import { PullRequestView } from './pullRequestOverviewCommon';
1313
import { isInCodespaces, parseReviewers } from './utils';
@@ -212,7 +212,7 @@ export class PullRequestViewProvider extends WebviewViewBase implements vscode.W
212212
this.registerPrSpecificListeners(pullRequestModel);
213213
}
214214
this._item = pullRequestModel;
215-
const [pullRequest, repositoryAccess, timelineEvents, requestedReviewers, branchInfo, defaultBranch, currentUser, viewerCanEdit, hasReviewDraft] = await Promise.all([
215+
const [pullRequest, repositoryAccess, timelineEvents, requestedReviewers, branchInfo, defaultBranch, currentUser, viewerCanEdit, hasReviewDraft, coAuthors] = await Promise.all([
216216
this._folderRepositoryManager.resolvePullRequest(
217217
pullRequestModel.remote.owner,
218218
pullRequestModel.remote.repositoryName,
@@ -226,6 +226,7 @@ export class PullRequestViewProvider extends WebviewViewBase implements vscode.W
226226
this._folderRepositoryManager.getCurrentUser(pullRequestModel.githubRepository),
227227
pullRequestModel.canEdit(),
228228
pullRequestModel.validateDraftMode(),
229+
pullRequestModel.getCoAuthors(),
229230
ensureEmojis(this._folderRepositoryManager.context)
230231
]);
231232

@@ -308,7 +309,8 @@ export class PullRequestViewProvider extends WebviewViewBase implements vscode.W
308309
isDarkTheme: vscode.window.activeColorTheme.kind === vscode.ColorThemeKind.Dark,
309310
isEnterprise: pullRequest.githubRepository.remote.isEnterprise,
310311
hasReviewDraft,
311-
currentUserReviewState: reviewState
312+
currentUserReviewState: reviewState,
313+
isCopilotOnMyBehalf: await isCopilotOnMyBehalf(pullRequest, currentUser, coAuthors)
312314
};
313315

314316
this._postMessage({

webviews/activityBarView/index.css

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,17 @@ form,
7575
width: 100%;
7676
}
7777

78-
.button-container button {
78+
.button-container>button {
79+
width: 100%;
80+
}
81+
82+
.button-container:has(> .dropdown-container) {
83+
display: flex;
84+
min-width: 0;
85+
}
86+
87+
.dropdown-container {
88+
flex-grow: 1;
7989
width: 100%;
8090
}
8191

webviews/components/merge.tsx

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -310,21 +310,21 @@ export const ReadyForReview = ({ isSimple, isCopilotOnMyBehalf, mergeMethod }: {
310310

311311
const allOptions = useCallback(() => {
312312
const actions: { label: string; value: string; action: (event: React.MouseEvent<HTMLButtonElement, MouseEvent>) => void }[] = [
313-
{
314-
label: 'Ready for Review',
315-
value: 'ready',
316-
action: markReadyForReview
313+
{
314+
label: 'Ready for Review',
315+
value: 'ready',
316+
action: markReadyForReview
317317
}
318318
];
319-
319+
320320
if (isCopilotOnMyBehalf) {
321-
actions.push({
322-
label: 'Ready, Approve, and Auto-Merge',
323-
value: 'readyAndMerge',
324-
action: markReadyAndMerge
321+
actions.push({
322+
label: 'Ready, Approve, and Auto-Merge',
323+
value: 'readyAndMerge',
324+
action: markReadyAndMerge
325325
});
326326
}
327-
327+
328328
return actions;
329329
}, [isCopilotOnMyBehalf, markReadyForReview, markReadyAndMerge]);
330330

0 commit comments

Comments
 (0)