Fix unpredictable markdown link text when copying permalink from gutter (#8252)

* Initial plan

* Initial analysis of permalink markdown text issue

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Fix unpredictable markdown link text when copying permalink from gutter

- Add range field to PermalinkInfo to track the range used for the permalink
- Update getMarkdownLinkText to accept and use the permalink range
- When copying markdown permalink, extract text from the correct line/range
- Fixes issue where right-clicking gutter would use previous selection text

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Add comment explaining NotebookRange exclusion in getMarkdownLinkText

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Full line length

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

Author: Copilot

src/issues/issueFeatureRegistrar.ts

@@ -1621,10 +1621,21 @@ ${options?.body ?? ''}\n
 		}
 	}
 
-	private getMarkdownLinkText(): string | undefined {
+	private getMarkdownLinkText(range?: vscode.Range | vscode.NotebookRange): string | undefined {
 		if (!vscode.window.activeTextEditor) {
 			return undefined;
 		}
+
+		// If a specific range is provided (e.g., from a gutter click), use that
+		// Note: NotebookRange is excluded because getText() only accepts vscode.Range
+		if (range && !(range instanceof vscode.NotebookRange)) {
+			const text = vscode.window.activeTextEditor.document.getText(range);
+			if (text) {
+				return text;
+			}
+		}
+
+		// Otherwise fall back to the current selection
 		let editorSelection: vscode.Range | undefined = vscode.window.activeTextEditor.selection;
 		if (editorSelection.start.line !== editorSelection.end.line) {
 			editorSelection = new vscode.Range(
@@ -1648,7 +1659,7 @@ ${options?.body ?? ''}\n
 		const withPermalinks: (PermalinkInfo & { permalink: string })[] = links.filter((link): link is PermalinkInfo & { permalink: string } => !!link.permalink);
 
 		if (withPermalinks.length === 1) {
-			const selection = this.getMarkdownLinkText();
+			const selection = this.getMarkdownLinkText(withPermalinks[0].range);
 			if (selection) {
 				return vscode.env.clipboard.writeText(`[${selection.trim()}](${withPermalinks[0].permalink})`);
 			}

src/issues/util.ts

@@ -225,7 +225,7 @@ function getFileAndPosition(context: LinkContext, positionInfo?: NewIssue): { ur
 		uri = fileUri;
 		if (vscode.window.activeTextEditor?.document.uri.fsPath === uri.fsPath && !vscode.window.activeNotebookEditor) {
 			if (lineNumber !== undefined && (vscode.window.activeTextEditor.selection.isEmpty || !vscode.window.activeTextEditor.selection.contains(new vscode.Position(lineNumber - 1, 0)))) {
-				range = new vscode.Range(new vscode.Position(lineNumber - 1, 0), new vscode.Position(lineNumber - 1, 1));
+				range = new vscode.Range(new vscode.Position(lineNumber - 1, 0), new vscode.Position(lineNumber - 1, vscode.window.activeTextEditor.document.lineAt(lineNumber - 1).text.length));
 			} else {
 				range = vscode.window.activeTextEditor.selection;
 			}
@@ -252,6 +252,7 @@ export interface PermalinkInfo {
 	permalink: string | undefined;
 	error: string | undefined;
 	originalFile: vscode.Uri | undefined;
+	range: vscode.Range | vscode.NotebookRange | undefined;
 }
 
 export function getSimpleUpstream(repository: Repository) {
@@ -311,12 +312,12 @@ export async function createSinglePermalink(
 ): Promise<PermalinkInfo> {
 	const { uri, range } = getFileAndPosition(context, positionInfo);
 	if (!uri) {
-		return { permalink: undefined, error: vscode.l10n.t('No active text editor position to create permalink from.'), originalFile: undefined };
+		return { permalink: undefined, error: vscode.l10n.t('No active text editor position to create permalink from.'), originalFile: undefined, range: undefined };
 	}
 
 	const repository = getRepositoryForFile(gitAPI, uri);
 	if (!repository) {
-		return { permalink: undefined, error: vscode.l10n.t('The current file isn\'t part of repository.'), originalFile: uri };
+		return { permalink: undefined, error: vscode.l10n.t('The current file isn\'t part of repository.'), originalFile: uri, range };
 	}
 
 	let commitHash: string | undefined;
@@ -328,7 +329,7 @@ export async function createSinglePermalink(
 		try {
 			const log = await repository.log({ maxEntries: 1, path: uri.fsPath });
 			if (log.length === 0) {
-				return { permalink: undefined, error: vscode.l10n.t('No branch on a remote contains the most recent commit for the file.'), originalFile: uri };
+				return { permalink: undefined, error: vscode.l10n.t('No branch on a remote contains the most recent commit for the file.'), originalFile: uri, range };
 			}
 			// Now that we know that the file existed at some point in the repo, use the head commit to construct the URI.
 			if (repository.state.HEAD?.commit && (log[0].hash !== repository.state.HEAD?.commit)) {
@@ -345,7 +346,7 @@ export async function createSinglePermalink(
 
 	const rawUpstream = await getBestPossibleUpstream(repositoriesManager, repository, commitHash);
 	if (!rawUpstream || !rawUpstream.fetchUrl) {
-		return { permalink: undefined, error: vscode.l10n.t('The selection may not exist on any remote.'), originalFile: uri };
+		return { permalink: undefined, error: vscode.l10n.t('The selection may not exist on any remote.'), originalFile: uri, range };
 	}
 	const upstream: Remote & { fetchUrl: string } = rawUpstream as Remote & { fetchUrl: string };
 
@@ -357,7 +358,8 @@ export async function createSinglePermalink(
 		permalink: (`${originOfFetchUrl}/${getOwnerAndRepo(repositoriesManager, repository, upstream)}/blob/${commitHash
 			}${includeFile ? `${encodedPathSegment}${includeRange ? rangeString(range) : ''}` : ''}`),
 		error: undefined,
-		originalFile: uri
+		originalFile: uri,
+		range
 	};
 	Logger.debug(`permalink generated: ${result.permalink}`, PERMALINK_COMPONENT);
 	return result;
@@ -431,11 +433,11 @@ export async function createSingleGitHubLink(
 ): Promise<PermalinkInfo> {
 	const { uri, range } = getFileAndPosition(context);
 	if (!uri) {
-		return { permalink: undefined, error: vscode.l10n.t('No active text editor position to create permalink from.'), originalFile: undefined };
+		return { permalink: undefined, error: vscode.l10n.t('No active text editor position to create permalink from.'), originalFile: undefined, range: undefined };
 	}
 	const folderManager = managers.getManagerForFile(uri);
 	if (!folderManager) {
-		return { permalink: undefined, error: vscode.l10n.t('Current file does not belong to an open repository.'), originalFile: undefined };
+		return { permalink: undefined, error: vscode.l10n.t('Current file does not belong to an open repository.'), originalFile: undefined, range: undefined };
 	}
 	let branchName = folderManager.repository.state.HEAD?.name;
 	if (!branchName) {
@@ -446,7 +448,7 @@ export async function createSingleGitHubLink(
 	}
 	const upstream = getSimpleUpstream(folderManager.repository);
 	if (!upstream?.fetchUrl) {
-		return { permalink: undefined, error: vscode.l10n.t('Repository does not have any remotes.'), originalFile: undefined };
+		return { permalink: undefined, error: vscode.l10n.t('Repository does not have any remotes.'), originalFile: undefined, range: undefined };
 	}
 	const pathSegment = uri.path.substring(folderManager.repository.rootUri.path.length);
 	const originOfFetchUrl = getUpstreamOrigin(upstream).replace(/\/$/, '');
@@ -455,7 +457,8 @@ export async function createSingleGitHubLink(
 		permalink: (`${originOfFetchUrl}/${new Protocol(upstream.fetchUrl).nameWithOwner}/blob/${encodedBranchAndFilePath
 			}${includeRange ? rangeString(range) : ''}`),
 		error: undefined,
-		originalFile: uri
+		originalFile: uri,
+		range
 	};
 }