From 2c2a6216ebf48de0de28850106ab8800d5a43b6d Mon Sep 17 00:00:00 2001 From: Yann Collet Date: Mon, 5 Oct 2026 15:55:37 -0700 Subject: [PATCH] ci: use the VS 2026 generator for the MSVC ARM64 job The windows-11-arm runner label now resolves to the windows-11-vs2026-arm64 image (20260924), which ships Visual Studio 2026 and CMake 4.4, but no longer Visual Studio 2022. CMake fails at configure time with "could not find any instance of Visual Studio", so the job fails on every PR opened since 2026-10-01 (e.g. #4806, #4811, #4813). Switch that matrix entry to the "Visual Studio 18 2026" generator. The x64 and Win32 entries run on windows-2022 and are unaffected. Drop "VS2022" from the job name template, which would now be wrong for the ARM64 entry: jobs become "CMake Windows ()". No branch protection rule requires these checks by name. --- .github/workflows/cmake-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cmake-tests.yml b/.github/workflows/cmake-tests.yml index 262c9ac15a1..4af2463569c 100644 --- a/.github/workflows/cmake-tests.yml +++ b/.github/workflows/cmake-tests.yml @@ -89,7 +89,7 @@ jobs: # Tests multiple generators and toolchains to ensure broad Windows compatibility # including MSVC (x64, Win32, ARM64), MinGW, and Clang-CL with various architectures and optimizations cmake-windows-comprehensive: - name: "CMake Windows VS2022 (${{ matrix.name }})" + name: "CMake Windows (${{ matrix.name }})" runs-on: ${{ matrix.runner }} strategy: fail-fast: false @@ -111,10 +111,10 @@ jobs: runner: "windows-2022" # Intentionally omit ZSTD_BUILD_TESTS to reproduce the CXX language configuration bug cmake_extra_flags: "-DCMAKE_COMPILE_WARNING_AS_ERROR=ON" - - generator: "Visual Studio 17 2022" + - generator: "Visual Studio 18 2026" # windows-11-arm image ships VS 2026 only flags: "-A ARM64" name: "MSVC ARM64" - runner: "windows-11-arm" # githuh runner for WOA instance + runner: "windows-11-arm" # github runner for WOA instance - generator: "MinGW Makefiles" flags: "" name: "MinGW"