fix: resolve all remaining lint errors

- Use importlib.util.find_spec for module availability checks
- Use contextlib.suppress instead of try-except-pass
- Use ternary operator for simple conditionals
- Remove unused method arguments

Author: medeirosdev

src/trueentropy/harvesters/network.py

@@ -119,10 +119,10 @@ def collect(self) -> HarvestResult:
         Returns:
             HarvestResult containing network timing entropy
         """
-        # Attempt import of requests library
-        try:
-            import requests
-        except ImportError:
+        # Check if requests library is available
+        import importlib.util
+
+        if importlib.util.find_spec("requests") is None:
             return HarvestResult(
                 data=b"",
                 entropy_bits=0,
@@ -132,7 +132,7 @@ def collect(self) -> HarvestResult:
             )
 
         # Collect latency measurements
-        measurements = self._measure_latencies(requests)
+        measurements = self._measure_latencies()
 
         if not measurements:
             return HarvestResult(
@@ -156,17 +156,14 @@ def collect(self) -> HarvestResult:
     # Private Methods
     # -------------------------------------------------------------------------
 
-    def _measure_latencies(self, requests_module: object) -> list[tuple[str, int]]:
+    def _measure_latencies(self) -> list[tuple[str, int]]:
         """
         Measure latency to each target server.
 
-        Args:
-            requests_module: The imported requests module
-
         Returns:
             List of (target, latency_ns) tuples for successful requests
         """
-        import requests  # Type ignore for the module passed in
+        import requests
 
         measurements: list[tuple[str, int]] = []
 

src/trueentropy/harvesters/system.py

@@ -84,10 +84,10 @@ def collect(self) -> HarvestResult:
         Returns:
             HarvestResult containing system state entropy
         """
-        # Attempt import of psutil
-        try:
-            import psutil
-        except ImportError:
+        # Check if psutil library is available
+        import importlib.util
+
+        if importlib.util.find_spec("psutil") is None:
             return HarvestResult(
                 data=b"",
                 entropy_bits=0,
@@ -97,7 +97,7 @@ def collect(self) -> HarvestResult:
             )
 
         # Collect system metrics
-        metrics = self._collect_metrics(psutil)
+        metrics = self._collect_metrics()
 
         # Convert to bytes
         data = self._metrics_to_bytes(metrics)
@@ -112,17 +112,14 @@ def collect(self) -> HarvestResult:
     # Private Methods
     # -------------------------------------------------------------------------
 
-    def _collect_metrics(self, psutil: object) -> list[tuple[str, int | float]]:
+    def _collect_metrics(self) -> list[tuple[str, int | float]]:
         """
         Collect various system metrics.
 
-        Args:
-            psutil: The imported psutil module
-
         Returns:
             List of (metric_name, value) tuples
         """
-        import psutil as ps  # For type hints
+        import psutil as ps
 
         metrics: list[tuple[str, int | float]] = []
 

src/trueentropy/persistence.py

@@ -89,10 +89,10 @@ def save_pool(pool: EntropyPool, path: PathLike, include_checksum: bool = True)
         _write_pool_state(f, state_data, include_checksum)
 
     # Set restrictive permissions on Unix systems
-    try:
+    import contextlib
+
+    with contextlib.suppress(OSError, AttributeError):
         os.chmod(path, 0o600)
-    except (OSError, AttributeError):
-        pass  # Windows or permission denied
 
 
 def load_pool(path: PathLike, verify_checksum: bool = True) -> EntropyPool:

src/trueentropy/pool.py

@@ -89,12 +89,7 @@ def __init__(self, seed: bytes | None = None) -> None:
         # Initialize the pool with random data
         # We use os.urandom() as the initial seed because it provides
         # cryptographically secure random bytes from the OS
-        if seed is not None:
-            # Use provided seed (useful for testing with deterministic output)
-            initial = seed
-        else:
-            # Use OS-provided entropy for production use
-            initial = os.urandom(self.POOL_SIZE)
+        initial = seed if seed is not None else os.urandom(self.POOL_SIZE)
 
         # Expand seed to full pool size if needed
         self._pool: bytes = self._expand_to_pool_size(initial)