fix(api): address Copilot review for validate script and recipes test

- validate_openapi_generated: use git diff --quiet with actionable messages;
  PORCELAIN in UPPER_SNAKE_CASE
- Rename bundled recipes test to test_resolve_recipes_json_path_loads_recipes

Made-with: Cursor

Author: mcalthrop

apps/api/recipes_api/repository_test.py

@@ -117,8 +117,8 @@ def test_duplicate_ids_raise(tmp_path: Path) -> None:
         StaticRecipeRepository(data_path=path)
 
 
-def test_bundled_recipes_json_loads() -> None:
-    """Packaged ``recipes.json`` loads (wheel/sdist layout)."""
+def test_resolve_recipes_json_path_loads_recipes() -> None:
+    """``recipes.json`` resolved via ``resolve_recipes_json_path`` loads successfully."""
     repo = StaticRecipeRepository(data_path=resolve_recipes_json_path())
     summaries = repo.list_summaries()
     ids = [summary["id"] for summary in summaries]

apps/api/scripts/validate_openapi_generated.sh

@@ -10,10 +10,16 @@ fi
 cd "${ROOT}"
 
 GENERATED_PATH="apps/api/recipes_api/generated"
-git diff --exit-code -- "${GENERATED_PATH}"
-PORCELAIN_CHANGES=$(git status --porcelain -- "${GENERATED_PATH}")
+if ! git diff --quiet -- "${GENERATED_PATH}"; then
+  echo "Generated OpenAPI files under ${GENERATED_PATH} are out of date." >&2
+  echo "Please run 'pnpm openapi:generate' and commit the updated files." >&2
+  git diff -- "${GENERATED_PATH}" >&2
+  exit 1
+fi
+
+PORCELAIN_CHANGES=$(git status --porcelain -- "${GENERATED_PATH}") || exit $?
 if [[ -n "${PORCELAIN_CHANGES}" ]]; then
-  echo "Untracked or uncommitted changes under ${GENERATED_PATH}. Regenerate and commit." >&2
+  echo "Untracked or uncommitted changes under ${GENERATED_PATH}. Regenerate with 'pnpm openapi:generate' and commit." >&2
   printf '%s\n' "${PORCELAIN_CHANGES}" >&2
   exit 1
 fi