Skip to content

Commit e70fadf

Browse files
committed
Fix addClass() and similar to not add extra blank in class
1 parent e7ee4e0 commit e70fadf

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

ts/adaptors/liteAdaptor.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -606,8 +606,9 @@ export class LiteBase extends AbstractDOMAdaptor<
606606
* @override
607607
*/
608608
public addClass(node: LiteElement, name: string) {
609-
const classes = ((node.attributes['class'] as string) || '').split(/ /);
610-
if (!classes.find((n) => n === name)) {
609+
const classString = node.attributes['class'] as string;
610+
const classes = classString?.split(/ /) || [];
611+
if (!classes.includes(name)) {
611612
classes.push(name);
612613
node.attributes['class'] = classes.join(' ');
613614
}
@@ -617,8 +618,9 @@ export class LiteBase extends AbstractDOMAdaptor<
617618
* @override
618619
*/
619620
public removeClass(node: LiteElement, name: string) {
620-
const classes = ((node.attributes['class'] as string) || '').split(/ /);
621-
const i = classes.findIndex((n) => n === name);
621+
const classString = node.attributes['class'] as string;
622+
const classes = classString?.split(/ /) || [];
623+
const i = classes.indexOf(name);
622624
if (i >= 0) {
623625
classes.splice(i, 1);
624626
node.attributes['class'] = classes.join(' ');
@@ -630,7 +632,7 @@ export class LiteBase extends AbstractDOMAdaptor<
630632
*/
631633
public hasClass(node: LiteElement, name: string) {
632634
const classes = ((node.attributes['class'] as string) || '').split(/ /);
633-
return !!classes.find((n) => n === name);
635+
return classes.includes(name);
634636
}
635637

636638
/**

0 commit comments

Comments
 (0)