Skip to content

Commit 433f7fc

Browse files
committed
incorporate review suggestions
1 parent 7eb75aa commit 433f7fc

5 files changed

Lines changed: 13 additions & 10 deletions

File tree

ts/input/tex/textmacros/TextMacrosConfiguration.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ export const TextBaseConfiguration = Configuration.create('text-base', {
5858
// produces the error as configured in the main TeX parser, so
5959
// this will respect the noundefined package, if loaded).
6060
//
61-
macro: (parser: TextParser, name: string) => {
61+
[HandlerType.MACRO]: (parser: TextParser, name: string) => {
6262
const texParser = parser.texParser;
6363
const macro = texParser.lookup(HandlerType.MACRO, name);
6464
if (macro && macro._func !== TextMacrosMethods.Macro) {
@@ -71,7 +71,7 @@ export const TextBaseConfiguration = Configuration.create('text-base', {
7171
texParser.parse(HandlerType.MACRO, [parser, name]);
7272
},
7373
},
74-
items: {
74+
[ConfigurationType.ITEMS]: {
7575
[StartItem.prototype.kind]: StartItem,
7676
[StopItem.prototype.kind]: StopItem,
7777
[MmlItem.prototype.kind]: MmlItem,
@@ -118,7 +118,10 @@ export const TextMacrosConfiguration = Configuration.create('textmacros', {
118118
* @param {ParserConfiguration} _config The configuration object we are being configured within
119119
* @param {TeX<any,any,any>} jax The TeX input jax in which we are running
120120
*/
121-
config(_config: ParserConfiguration, jax: TeX<any, any, any>) {
121+
[ConfigurationType.CONFIG]: (
122+
_config: ParserConfiguration,
123+
jax: TeX<any, any, any>
124+
) => {
122125
//
123126
// Create the configuration and parseOptions objects for the
124127
// internal TextParser and add the textBase configuration.

ts/output/common.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ export abstract class CommonOutputJax<
215215
>;
216216

217217
/**
218-
* @returns {boolean} True when inkline breaks need to be forced (e.g., for
218+
* @returns {boolean} True when in-line breaks need to be forced (e.g., for
219219
* SVG output)
220220
*/
221221
get forceInlineBreaks(): boolean {
@@ -676,7 +676,7 @@ export abstract class CommonOutputJax<
676676

677677
/**
678678
* @param {N} node The math element to be measured
679-
* @param {boolean} display Is the element is display math?
679+
* @param {boolean} display Is the element in display math?
680680
* @returns {N} The test elements that were added
681681
*/
682682
protected getTestElement(node: N, display: boolean): N {

ts/output/common/Notation.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,11 +118,11 @@ export const sideNames = Object.keys(sideIndex) as Side[];
118118
* @param {Menclose} node The enclose node
119119
* @returns {BBoxExtender<Menclose>} The bbox extender
120120
*/
121-
export const fullBBox = ((node: Menclose) =>
121+
export const fullBBox = ((node) =>
122122
new Array(4).fill(node.thickness + node.padding)) as BBoxExtender<Menclose>;
123-
export const fullPadding = ((node: Menclose) =>
123+
export const fullPadding = ((node) =>
124124
new Array(4).fill(node.padding)) as BBoxExtender<Menclose>;
125-
export const fullBorder = ((node: Menclose) =>
125+
export const fullBorder = ((node) =>
126126
new Array(4).fill(node.thickness)) as BBoxBorder<Menclose>;
127127

128128
/*****************************************************************/

ts/output/common/Wrappers/XmlNode.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ export function CommonXmlNodeMixin<
278278
/**
279279
* The font-size and font-family values to use for the XML
280280
*
281-
* @returns {{'font-family': string, 'font-size': string}} The font info
281+
* @returns {StyleList} The font info
282282
*/
283283
public getFontStyles(): { 'font-family': string; 'font-size': string } {
284284
const adaptor = this.adaptor;

ts/ui/menu/Menu.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1105,7 +1105,7 @@ export class Menu {
11051105
/**
11061106
* Add extensions that need to be loaded when the renderer changes
11071107
*
1108-
* @param {string[] }extensions The list of extensions
1108+
* @param {string[]} extensions The list of extensions
11091109
*/
11101110
public addRequiredExtensions(extensions: string[]) {
11111111
if (extensions) {

0 commit comments

Comments
 (0)