Merge pull request #1172 from mathics/sanitizeloadmodules

Check fails in loading modules.

Author: rocky

mathics/builtin/__init__.py

@@ -1,12 +1,11 @@
-#!/usr/bin/env python3
 # -*- coding: utf-8 -*-
-from mathics.core.expression import ensure_context
 
 import glob
 import importlib
 import re
 import os.path as osp
 from mathics.settings import ENABLE_FILES_MODULE
+from mathics.version import __version__  # noqa used in loading to check consistency.
 
 # Get a list of file in this directory. We'll exclude from the start
 # files with leading characters we don't want like __init__ with its leading underscore.
@@ -23,8 +22,6 @@
     PatternObject,
 )
 
-from mathics.settings import ENABLE_FILES_MODULE
-
 exclude_files = set(("files", "codetables", "base", "importexport", "colors"))
 module_names = [
     f for f in __py_files__ if re.match("^[a-z0-9]+$", f) if f not in exclude_files
@@ -38,9 +35,17 @@
 for module_name in module_names:
     try:
         module = importlib.import_module("mathics.builtin." + module_name)
-    except:
-        # print("XXX", module_name)
+    except Exception as e:
+        print(e)
+        print(f"    Not able to load {module_name}. Check your installation.")
+        print(f"    mathics.builtin loads from {__file__[:-11]}")
         continue
+
+    if __version__ != module.__version__:
+        print(
+            f"Version {module.__version__} in the module do not match with {__version__}"
+        )
+
     modules.append(module)
 
 _builtins = []
@@ -75,7 +80,7 @@ def is_builtin(var):
                 # This set the default context for symbols in mathics.builtins
                 if not type(instance).context:
                     type(instance).context = "System`"
-                _builtins.append( (instance.get_name(), instance))
+                _builtins.append((instance.get_name(), instance))
                 builtins_by_module[module.__name__].append(instance)
 
 
@@ -113,9 +118,11 @@ def add_builtins(new_builtins):
 
 
 def builtins_dict():
-    return { builtin.get_name() : builtin
-             for modname, builtins in builtins_by_module.items()
-             for builtin in builtins}
+    return {
+        builtin.get_name(): builtin
+        for modname, builtins in builtins_by_module.items()
+        for builtin in builtins
+    }
 
 
 def get_module_doc(module):

mathics/builtin/algebra.py

@@ -1,9 +1,9 @@
-#!/usr/bin/env python3
 # -*- coding: utf-8 -*-
 """
 Algebraic Manipulation
 """
 
+from mathics.version import __version__  # noqa used in loading to check consistency.
 
 from mathics.builtin.base import Builtin
 from mathics.core.expression import Expression, Integer, Symbol, Atom, Number

mathics/builtin/arithmetic.py

@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 # -*- coding: utf-8 -*-
 # cython: language_level=3
 
@@ -8,7 +7,7 @@
 Basic arithmetic functions, including complex number arithmetic.
 """
 
-
+from mathics.version import __version__  # noqa used in loading to check consistency.
 import sympy
 import mpmath
 

mathics/builtin/assignment.py

@@ -1,5 +1,7 @@
 # -*- coding: utf-8 -*-
 
+from mathics.version import __version__  # noqa used in loading to check consistency.
+
 import mathics.builtin
 from mathics.builtin.base import (
     Builtin, BinaryOperator, PostfixOperator, PrefixOperator)

mathics/builtin/attributes.py

@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 # -*- coding: utf-8 -*-
 
 r"""
@@ -8,9 +7,9 @@
 However, you can set any symbol as an attribute, in contrast to \Mathematica.
 """
 
+from mathics.version import __version__  # noqa used in loading to check consistency.
 
 from mathics.builtin.base import Predefined, Builtin
-from mathics.builtin.evaluation import Sequence
 from mathics.core.expression import Expression, Symbol, SymbolNull, String
 from mathics.builtin.assignment import get_symbol_list
 

mathics/builtin/base.py

@@ -1,4 +1,3 @@
-#!/usr/bin/env python3
 # -*- coding: utf-8 -*-
 
 import re
@@ -10,6 +9,8 @@
 import typing
 from typing import Any, cast
 
+from mathics.version import __version__  # noqa used in loading to check consistency.
+
 from mathics.core.definitions import Definition
 from mathics.core.parser.util import SystemDefinitions, PyMathicsDefinitions
 from mathics.core.rules import Rule, BuiltinRule, Pattern
@@ -26,6 +27,7 @@
 )
 from mathics.core.numbers import get_precision, PrecisionValueError
 
+
 def get_option(options, name, evaluation, pop=False, evaluate=True):
     # we do not care whether an option X is given as System`X,
     # Global`X, or with any prefix from $ContextPath for that
@@ -82,6 +84,7 @@ def __init__(self, *args, **kwargs):
 
     def contribute(self, definitions, is_pymodule=False):
         from mathics.core.parser import parse_builtin_rule
+
         # Set the default context
         if not self.context:
             self.context = "Pymathics`" if is_pymodule else "System`"
@@ -102,7 +105,8 @@ def contribute(self, definitions, is_pymodule=False):
                 # used, so it won't work.
                 if option not in definitions.builtin:
                     definitions.builtin[option] = Definition(
-                        name=name, attributes=set())
+                        name=name, attributes=set()
+                    )
 
         # Check if the given options are actually supported by the Builtin.
         # If not, we might issue an optx error and abort. Using '$OptionSyntax'
@@ -144,9 +148,7 @@ def check_options(options_to_check, evaluation):
 
         for pattern, function in self.get_functions(is_pymodule=is_pymodule):
             rules.append(
-                BuiltinRule(
-                    name, pattern, function, check_options, system=True
-                )
+                BuiltinRule(name, pattern, function, check_options, system=True)
             )
         for pattern, replace in self.rules.items():
             if not isinstance(pattern, BaseExpression):
@@ -246,7 +248,8 @@ def contextify_form_name(f):
                 # used, so it won't work.
                 if option not in definitions.builtin:
                     definitions.builtin[option] = Definition(
-                        name=name, attributes=set())
+                        name=name, attributes=set()
+                    )
         defaults = []
         for spec, value in self.defaults.items():
             value = parse_builtin_rule(value)
@@ -266,7 +269,7 @@ def contextify_form_name(f):
             attributes=attributes,
             options=options,
             defaultvalues=defaults,
-            builtin=self
+            builtin=self,
         )
         if is_pymodule:
             definitions.pymathics[name] = definition
@@ -537,7 +540,7 @@ def get_constant(self, precision, evaluation, have_mpmath=False):
 
         sympy_fn = self.to_sympy()
         if d is None:
-            result = self.get_mpmath_function()if have_mpmath else sympy_fn()
+            result = self.get_mpmath_function() if have_mpmath else sympy_fn()
             return MachineReal(result)
         else:
             return PrecisionReal(sympy_fn.n(d))
@@ -630,15 +633,15 @@ def head(self):
 
     @head.setter
     def head(self, value):
-        raise ValueError('BoxConstruct.head is write protected.')
+        raise ValueError("BoxConstruct.head is write protected.")
 
     @property
     def leaves(self):
         return self._leaves
 
     @leaves.setter
     def leaves(self, value):
-        raise ValueError('BoxConstruct.leaves is write protected.')
+        raise ValueError("BoxConstruct.leaves is write protected.")
 
     # I need to repeat this, because this is not
     # an expression...
@@ -663,14 +666,17 @@ def has_form(self, heads, *leaf_counts):
         if leaf_counts and leaf_counts[0] is not None:
             count = len(self._leaves)
             if count not in leaf_counts:
-                if (len(leaf_counts) == 2 and   # noqa
-                    leaf_counts[1] is None and count >= leaf_counts[0]):
+                if (
+                    len(leaf_counts) == 2
+                    and leaf_counts[1] is None  # noqa
+                    and count >= leaf_counts[0]
+                ):
                     return True
                 else:
                     return False
         return True
 
-    def flatten_pattern_sequence(self, evaluation)  -> 'BoxConstruct':
+    def flatten_pattern_sequence(self, evaluation) -> "BoxConstruct":
         return self
 
     def get_option_values(self, leaves, **options):
@@ -681,6 +687,7 @@ def get_option_values(self, leaves, **options):
             default.update(options)
         else:
             from mathics.core.parser import parse_builtin_rule
+
             default = {}
             for option, value in self.options.items():
                 option = ensure_context(option)