test(goals): keep the two Goal projections distinct now that both ship

CI `test-shard (2)` caught a real conflict I had missed: `#4248` shipped
`goal_acceptance_observation_projection_v0` as bounded historical evidence and
guarded that it is *not* the full lifecycle contract, partly by asserting the
collected Goal carries no `artifact_lifecycle` key at all. Attaching the real
lifecycle projection made that guard fail (2100 passed, 1 failed).

The guard's intent was the distinction, not the absence, so this preserves the
intent under the new reality instead of deleting the assertion. The collection
test now requires both projections to be present under their own keys with
their own schema versions, and requires the phase/milestone/transition
vocabulary to belong to the lifecycle projection alone.

The smoke gains the symmetric renderer check `#4248` established for its own
renderer: each renderer must refuse the other's schema rather than print a
half-understood payload under its own heading. Verified by mutation — relaxing
the lifecycle renderer's schema check to "any non-empty payload" makes it print
`phase=unknown milestones=0/0` for an acceptance observation, and the new
assertion fails.

`test_markdown_rejects_the_distinct_full_lifecycle_contract` is untouched and
still passes.

Signed-off-by: song <liusongstep@gmail.com>

Author: songoow

examples/control_plane/goal-artifact-lifecycle-projection-smoke.py

@@ -401,6 +401,49 @@ def assert_status_collection_attaches_a_readable_readout() -> None:
     assert_no_public_leak(projection)
 
 
+def assert_the_two_goal_projections_stay_distinct() -> None:
+    """The lifecycle contract and the narrow acceptance observation must not mix.
+
+    `#4248` shipped `goal_acceptance_observation_projection_v0` as bounded
+    historical evidence and guarded that it is not the full lifecycle contract.
+    Both now ship, so each renderer must refuse the other's schema rather than
+    print a half-understood payload under its own heading.
+    """
+
+    from loopx.presentation.renderers.goal_acceptance_observation_markdown import (
+        append_goal_acceptance_observation_markdown,
+    )
+    from loopx.presentation.renderers.goal_artifact_lifecycle_markdown import (
+        append_goal_artifact_lifecycle_markdown,
+    )
+
+    lifecycle = build_goal_artifact_lifecycle_projection(
+        goal_id=GOAL_ID, goal={"id": GOAL_ID, "status": "active"}
+    )
+    narrow = {
+        "schema_version": "goal_acceptance_observation_projection_v0",
+        "guards": [],
+        "acceptance_gaps": [],
+        "historical_progress": [],
+    }
+    # Each renderer prints only its own contract, whichever key carries it.
+    for goal in ({"artifact_lifecycle": narrow}, {"artifact_lifecycle": {}}):
+        lines: list[str] = []
+        append_goal_artifact_lifecycle_markdown(lines, goal)
+        assert lines == [], (goal, lines)
+    for goal in ({"acceptance_observation": lifecycle}, {"acceptance_observation": {}}):
+        lines = []
+        append_goal_acceptance_observation_markdown(lines, goal)
+        assert lines == [], (goal, lines)
+    # And the lifecycle renderer does print its own contract.
+    lines = []
+    append_goal_artifact_lifecycle_markdown(lines, {"artifact_lifecycle": lifecycle})
+    assert any("artifact lifecycle" in line for line in lines), lines
+    # The phase/milestone/transition vocabulary belongs to the lifecycle alone.
+    assert {"lifecycle_phase", "milestones", "next_transitions"} <= set(lifecycle)
+    assert {"lifecycle_phase", "milestones", "next_transitions"}.isdisjoint(narrow)
+
+
 def assert_control_plane_imports_no_presentation_module() -> None:
     """The projection may not depend outward on the presentation layer."""
 
@@ -433,6 +476,7 @@ def main() -> int:
     assert_batch_scale_never_promotes_an_outcome()
     assert_status_collection_attaches_a_readable_readout()
     assert_control_plane_imports_no_presentation_module()
+    assert_the_two_goal_projections_stay_distinct()
     print("goal-artifact-lifecycle-projection-smoke ok")
     return 0
 

tests/control_plane/test_goal_acceptance_observation.py

@@ -203,9 +203,17 @@ def test_real_collection_preserves_acceptance_before_display_run_trimming(tmp_pa
     result = collect_fixture(tmp_path)
     goal = result["run_history"]["goals"][0]
     assert goal["latest_runs"] == []
-    assert "artifact_lifecycle" not in goal
     projection = goal["acceptance_observation"]
     assert projection["schema_version"] == "goal_acceptance_observation_projection_v0"
+    # The full lifecycle contract now ships beside this one. They stay distinct
+    # projections under distinct keys and schema versions: this observation is
+    # bounded historical evidence, never the lifecycle's phase/milestone answer.
+    lifecycle = goal["artifact_lifecycle"]
+    assert lifecycle["schema_version"] == "goal_artifact_lifecycle_projection_v0"
+    assert lifecycle["schema_version"] != projection["schema_version"]
+    # Only the lifecycle projection answers phase, milestones and transitions.
+    assert {"lifecycle_phase", "milestones", "next_transitions"} <= set(lifecycle)
+    assert {"lifecycle_phase", "milestones", "next_transitions"}.isdisjoint(projection)
     assert (
         projection["acceptance_gaps"][0]["evidence_required"]
         == "Independent verification report"